Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QNN EP/Quantization] Add MinimumRealRange extra option to quantization script #18278

Merged
merged 15 commits into from
Nov 9, 2023

Conversation

adrianlizarraga
Copy link
Contributor

@adrianlizarraga adrianlizarraga commented Nov 3, 2023

Description

Adds the extra option MinimumRealRange to the quantization script:

"""
MinimumRealRange= float|None :
                    Default is None. If set to a floating-point value, the calculation of the quantization parameters
                    (i.e., scale and zero point) will enforce a minimum range between rmin and rmax. If (rmax - rmin)
                    is less than the specified minimum range, rmax will be set to rmin + QuantMinRealRange. This is
                    necessary for EPs like QNN that require a minimum floating-point range when determining
                    quantization parameters.
"""

Motivation and Context

QNN requires a minimum floating-point range of 0.0001.

@adrianlizarraga adrianlizarraga marked this pull request as ready for review November 4, 2023 01:23
@adrianlizarraga adrianlizarraga changed the title [QNN EP/Quantization] Add QuantMinRealRange extra option to quantization script [QNN EP/Quantization] Add MinimumRealRange extra option to quantization script Nov 8, 2023
Copy link
Member

@yufenglee yufenglee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@adrianlizarraga adrianlizarraga merged commit f237b0b into main Nov 9, 2023
91 checks passed
@adrianlizarraga adrianlizarraga deleted the adrianl/quantization-min-real-range branch November 9, 2023 18:55
kleiti pushed a commit to kleiti/onnxruntime that referenced this pull request Mar 22, 2024
…on script (microsoft#18278)

### Description
Adds the extra option `MinimumRealRange` to the quantization script:

```python3
"""
MinimumRealRange= float|None :
                    Default is None. If set to a floating-point value, the calculation of the quantization parameters
                    (i.e., scale and zero point) will enforce a minimum range between rmin and rmax. If (rmax - rmin)
                    is less than the specified minimum range, rmax will be set to rmin + QuantMinRealRange. This is
                    necessary for EPs like QNN that require a minimum floating-point range when determining
                    quantization parameters.
"""
```

### Motivation and Context
QNN requires a minimum floating-point range of 0.0001.

---------

Signed-off-by: adrianlizarraga <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants