Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JS/Web] Added Unifroms support to unary ops. #18223

Merged
merged 7 commits into from
Nov 3, 2023

Conversation

satyajandhyala
Copy link
Contributor

Description

Added uniforms support to unary ops.

Motivation and Context

Improve performance

Copy link
Contributor

@qjia7 qjia7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the shaderCache: {hint: cacheKey} to shaderCache: {hint: cacheKey, , inputDependencies: ['type']}. Otherwise, the unary still depends on 'dims' of all inputs.

@satyajandhyala satyajandhyala marked this pull request as ready for review November 2, 2023 15:43
@satyajandhyala satyajandhyala added the ep:WebGPU ort-web webgpu provider label Nov 2, 2023
Copy link
Contributor

@qjia7 qjia7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@satyajandhyala satyajandhyala merged commit e207060 into main Nov 3, 2023
55 of 57 checks passed
@satyajandhyala satyajandhyala deleted the sajandhy/webgpu_unifroms_suport_unary_ops branch November 3, 2023 16:30
kleiti pushed a commit to kleiti/onnxruntime that referenced this pull request Mar 22, 2024
### Description
Added uniforms support to unary ops.


### Motivation and Context
Improve performance
siweic0 pushed a commit to siweic0/onnxruntime-web that referenced this pull request May 9, 2024
### Description
Added uniforms support to unary ops.


### Motivation and Context
Improve performance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ep:WebGPU ort-web webgpu provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants