-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JS/Web] Added Unifroms support to unary ops. #18223
[JS/Web] Added Unifroms support to unary ops. #18223
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change the shaderCache: {hint: cacheKey}
to shaderCache: {hint: cacheKey, , inputDependencies: ['type']}
. Otherwise, the unary still depends on 'dims' of all inputs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
### Description Added uniforms support to unary ops. ### Motivation and Context Improve performance
### Description Added uniforms support to unary ops. ### Motivation and Context Improve performance
Description
Added uniforms support to unary ops.
Motivation and Context
Improve performance