Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block-wise 4b quantization matmul operator change #18172

Merged
merged 16 commits into from
Nov 3, 2023
+482 −444
Merged

Block-wise 4b quantization matmul operator change #18172

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
1eca861
MatMulNBits cpu and cuda changes
chenfucn Oct 26, 2023
34e266d
python change
chenfucn Oct 30, 2023
04498ce
add quantization fp16 instantiation
chenfucn Oct 30, 2023
c628dbd
fix python test
chenfucn Oct 30, 2023
80eab05
lint
chenfucn Oct 30, 2023
3fb8ea0
lintrunner
chenfucn Oct 30, 2023
bd1e034
Update onnxruntime/contrib_ops/cpu/quantization/matmul_nbits.cc
chenfucn Oct 31, 2023
1bcba51
Apply suggestions from code review
chenfucn Oct 31, 2023
da19fa9
replace dequant
chenfucn Oct 31, 2023
c4148e3
dequant adjustment
chenfucn Nov 1, 2023
53e703e
optimize dequant
chenfucn Nov 1, 2023
3a565c8
dequant tail adjustment
chenfucn Nov 1, 2023
b05046e
split dequant impl
chenfucn Nov 1, 2023
35978ce
lint
chenfucn Nov 1, 2023
9362e45
Add quant bits to template parameter
chenfucn Nov 2, 2023
8fb8993
lint
chenfucn Nov 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
129 changes: 0 additions & 129 deletions onnxruntime/contrib_ops/cpu/quantization/blockwise_quant_block.h
View file
Open in desktop

This file was deleted.

174 changes: 0 additions & 174 deletions onnxruntime/contrib_ops/cpu/quantization/dequantize_blockwise.h
View file
Open in desktop

This file was deleted.

25 changes: 14 additions & 11 deletions onnxruntime/contrib_ops/cpu/quantization/matmul_nbits.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,7 @@
#include "core/framework/op_kernel.h"
#include "core/providers/cpu/math/matmul_helper.h"
#include "core/providers/common.h"
#include "dequantize_blockwise.h"
#include "core/mlas/inc/mlas.h"
#include "core/mlas/inc/mlas_q4.h"

namespace onnxruntime {
namespace contrib {
Expand All @@ -18,6 +17,7 @@
ORT_ENFORCE(Status::OK() == info.GetAttr<int64_t>("N", &N_));
ORT_ENFORCE(Status::OK() == info.GetAttr<int64_t>("block_size", &block_size_));
ORT_ENFORCE(Status::OK() == info.GetAttr<int64_t>("bits", &nbits_));
ORT_ENFORCE(nbits_ == 4, "Only 4b quantization is supported for MatMulNBits op, additional bits support is planned.");

Check warning on line 20 in onnxruntime/contrib_ops/cpu/quantization/matmul_nbits.cc

View workflow job for this annotation

GitHub Actions / Lint C++ 

[cpplint] reported by reviewdog 🐶
 Lines should be <= 120 characters long  [whitespace/line_length] [2]

Raw Output:
onnxruntime/contrib_ops/cpu/quantization/matmul_nbits.cc:20:  Lines should be <= 120 characters long  [whitespace/line_length] [2]
}

Status Compute(OpKernelContext* context) const override;
Expand All @@ -27,6 +27,7 @@
int64_t N_;
int64_t block_size_;
int64_t nbits_;
bool column_wise_quant_{true};
};

Status MatMulNBits::Compute(OpKernelContext* ctx) const {
Expand All @@ -46,15 +47,17 @@
auto status = ctx->GetTempSpaceAllocator(&allocator);
ORT_RETURN_IF_ERROR(status);
auto tmp_b_data_ptr = IAllocator::MakeUniquePtr<float>(allocator, SafeInt<size_t>(K_) * N_);
DequantizeBlockwise<float>(tmp_b_data_ptr.get(),
b_data,
scales_data,
zero_points_data,
static_cast<int32_t>(block_size_),
static_cast<int32_t>(nbits_),
static_cast<int32_t>(N_),
static_cast<int32_t>(K_),
thread_pool);

chenfucn marked this conversation as resolved.
Show resolved Hide resolved
MlasDequantizeBlockwise<float>(
tmp_b_data_ptr.get(), // dequantized output
b_data, // quantized input
scales_data, // quantization scales
zero_points_data, // quantization zero points
static_cast<int32_t>(block_size_), // quantization block size
column_wise_quant_, // columnwise quantization or row-wise
static_cast<int32_t>(K_), // number of rows in quantized input
static_cast<int32_t>(N_), // number of columns in quantized input
thread_pool);

#if 0 // for debug
auto tm_b_data_ptr_trans = IAllocator::MakeUniquePtr<float>(allocator, SafeInt<size_t>(K_) * N_);
Expand Down
Loading
Loading