Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[js/web/training] runEvalStep & runOptimizerStep implementations #18117

Closed
wants to merge 35 commits into from
Closed

[js/web/training] runEvalStep & runOptimizerStep implementations #18117

wants to merge 35 commits into from

Conversation

carzh
Copy link
Contributor

@carzh carzh commented Oct 26, 2023

Description

  • implemented runEvalStep & runOptimizerStep
  • as part of this work, abstracted out similarities between runEvalStep and runTrainStep
  • updated the js/common interface
    • now includes evalInputNames and evalOutputNames as fields in TrainingSession
    • TrainingSession also includes private boolean values for hasEvalModel and hasOptimizerModel so that method calls that require an evalModel/optimizerModel to be loaded can throw an error at the TrainingSession level
    • updated the TrainingSessionHandler interface to include evalInputNames and evalOutputNames as well.

Motivation and Context

carzh and others added 30 commits October 2, 2023 14:54
@carzh
added training build configuration
cff6a7f
@carzh
edited wasm factory + added training backend
7a1365d
@carzh
added package.json modification for training + minimized training art…
71f9dbc 
…ifact
@carzh
applied suggestions
5adbcf4
@carzh
create training session implementation + supporting changes
9068ab4
@fs-eire
Merge remote-tracking branch 'origin/main' into carzh/training-wasm-b…
edbe9cc 
…inding
@carzh
fixed variable names + enforced wasmBackend being a singleton with su…
5202e3b 
…ggested fix of adding backend-wasm-inference.ts
@carzh
format + lint
a277347
@carzh
Merge branch 'main' into carzh/training-wasm-binding
adfa5cf
@carzh
Merge branch 'carzh/training-wasm-binding' into carzh/create-training…
c9931ad 
…-session
@carzh
minor tweak to remove placeholder return statement
e775933
@carzh
format
c745a65
@carzh
lint fixes
beca6dc
@carzh
lint + format
b37e77f
@carzh
Merge branch 'main' into carzh/create-training-session
8c1e227
@carzh
added isOrtEnvInitialized case to proxy wrapper
d2f3d88
@carzh
Merge remote-tracking branch 'refs/remotes/origin/carzh/create-traini…
712e73c 
…ng-session' into carzh/create-training-session
@carzh
fixed proxy wrapper case statement
05a708f 
fixed proxy worker

run format
@carzh
working runTrainStep implementation
46a9677
@carzh
light refactoring
3ca1c27 
renamed session-handler for inference files

lint + format
@carzh
updated getInputOutputCount and getInputOutputNames signature, added …
daa1023 
…more informative error message
@carzh
updated parameter names according to suggestions
389f08e
@carzh
format + lint
70505c4
@carzh
lint fix -- changed multiline string to singlequote string
a5bc60c
@carzh
getContiguousParameters & loadParametersBuffer impl
b44b705 
wrote untested getContiguousParameters method

updated getInputOutputCount and getInputOutputNames signature, added more informative error message

updated parameter names according to suggestions

semi working getContiguousParameters impl

working getContiguousParams, started writing loadParametersBuffer

working version of loadParametersBuffer
@carzh
lint + format + added error code checking wrapper
c74112e
@carzh
added runOptimizerStep and runEvalStep to interface
f425083
@carzh
enforced that loadParametersBuffer takes in a buffer that matches the…
cd2e4fa 
… number of parameters
@carzh
Merge branch 'carzh/web-parameters-methods' into carzh/web-runstep-me…
fa9f9ee 
…thods
@carzh
wrote evalStep and optimizerStep impl + refactoring similarities
799f54d
@carzh carzh closed this Nov 2, 2023
@carzh carzh deleted the carzh/web-runstep-methods branch December 20, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carzh @fs-eire