Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CUDA] Update GroupNorm and Add SkipGroupNorm #18091

Merged
merged 13 commits into from
Oct 31, 2023
Merged

Conversation

tianleiwu
Copy link
Contributor

@tianleiwu tianleiwu commented Oct 25, 2023

Description

  • Update GroupNorm kernel to support number of channels used in SD XL refiner.
  • Add epsilon in kernel
  • Add parity and performance test script
  • Add a new operator SkipGroupNorm to support skip and bias inputs.
  • Remove many limitations including max batch size, max number of groups, c % cPerBlock ==0 etc.

Motivation and Context

Update GroupNorm to support SD XL Refiner and beyond.

@tianleiwu tianleiwu marked this pull request as draft October 25, 2023 14:58
@faxu faxu added triage:approved Approved for cherrypicks for release sdxl_llama labels Oct 25, 2023
@tianleiwu tianleiwu force-pushed the tlwu/group_norm_nhwc_v2 branch from 328aaf4 to 3123d66 Compare October 26, 2023 08:48
@tianleiwu tianleiwu force-pushed the tlwu/group_norm_nhwc_v2 branch from 5d5c14e to ffce23f Compare October 27, 2023 19:21
@tianleiwu tianleiwu force-pushed the tlwu/group_norm_nhwc_v2 branch from ffce23f to 3d25e85 Compare October 28, 2023 00:17
@tianleiwu tianleiwu marked this pull request as ready for review October 28, 2023 18:03
yufenglee
yufenglee previously approved these changes Oct 30, 2023
Copy link
Member

@yufenglee yufenglee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@tianleiwu tianleiwu changed the title [CUDA] Update GroupNorm kernel [CUDA] Update GroupNorm and Add SkipGroupNorm Oct 30, 2023
yufenglee
yufenglee previously approved these changes Oct 30, 2023
Copy link
Member

@yufenglee yufenglee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@tianleiwu tianleiwu merged commit 95f053c into main Oct 31, 2023
93 of 95 checks passed
@tianleiwu tianleiwu deleted the tlwu/group_norm_nhwc_v2 branch October 31, 2023 17:27
tianleiwu added a commit that referenced this pull request Oct 31, 2023
* Add a new operator SkipGroupNorm to support skip and bias inputs.
* Update GroupNorm kernel to support number of channels used in SD XLrefiner.
* Add epsilon in kernel
* Add parity and performance test script
* Remove many limitations including max batch size, max number of groups, c % cPerBlock ==0 etc.

### Motivation and Context

Update GroupNorm to support SD XL Refiner and beyond.
@tianleiwu tianleiwu removed triage:approved Approved for cherrypicks for release release:1.16.2 labels Nov 1, 2023
kleiti pushed a commit to kleiti/onnxruntime that referenced this pull request Mar 22, 2024
* Add a new operator SkipGroupNorm to support skip and bias inputs.
* Update GroupNorm kernel to support number of channels used in SD XLrefiner.
* Add epsilon in kernel
* Add parity and performance test script
* Remove many limitations including max batch size, max number of groups, c % cPerBlock ==0 etc.

### Motivation and Context

Update GroupNorm to support SD XL Refiner and beyond.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants