Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]EP interface #18090

Draft
wants to merge 36 commits into
base: main
Choose a base branch
from

postpone kernel creation

021405f
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Draft

[WIP]EP interface #18090

postpone kernel creation
021405f
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
GitHub Actions / cpplint completed Oct 28, 2023 in 3s

reviewdog [cpplint] report

reported by reviewdog 🐶

Findings (189)

include/onnxruntime/core/framework/allocator.h|11| Found C++ system header after other header. Should be: allocator.h, c system, c++ system, other. [build/include_order] [4]
include/onnxruntime/core/framework/allocator.h|12| Found C++ system header after other header. Should be: allocator.h, c system, c++ system, other. [build/include_order] [4]
include/onnxruntime/core/framework/node_compute_info.h|17| Namespace should be terminated with "// namespace onnxruntime" [readability/namespace] [5]
include/onnxruntime/core/framework/op_kernel_context.h|49| Should have a space between // and comment [whitespace/comments] [4]
include/onnxruntime/core/session/environment.h|18| Single-parameter constructors should be marked explicit. [runtime/explicit] [5]
include/onnxruntime/core/session/environment.h|20| Lines should be <= 120 characters long [whitespace/line_length] [2]
include/onnxruntime/core/session/environment.h|27| Lines should be <= 120 characters long [whitespace/line_length] [2]
include/onnxruntime/core/session/environment.h|113| Lines should be <= 120 characters long [whitespace/line_length] [2]
include/onnxruntime/core/session/environment.h|126| Add #include for string [build/include_what_you_use] [4]
include/onnxruntime/core/session/environment.h|126| Add #include <unordered_map> for unordered_map<> [build/include_what_you_use] [4]
include/onnxruntime/core/session/onnxruntime_c_api.h|4516| Lines should be <= 120 characters long [whitespace/line_length] [2]
include/onnxruntime/core/session/onnxruntime_c_api.h|4518| Lines should be <= 120 characters long [whitespace/line_length] [2]
include/onnxruntime/interface/common/data_types.h|25| Namespace should be terminated with "// namespace interface" [readability/namespace] [5]
include/onnxruntime/interface/common/data_types.h|27| Could not find a newline character at the end of the file. [whitespace/ending_newline] [5]
include/onnxruntime/interface/framework/Tensor.h|12| Could not find a newline character at the end of the file. [whitespace/ending_newline] [5]
include/onnxruntime/interface/framework/kernel.h|32| Should have a space between // and comment [whitespace/comments] [4]
include/onnxruntime/interface/framework/kernel.h|33| You don't need a ; after a } [readability/braces] [4]
include/onnxruntime/interface/framework/kernel.h|33| Constructors callable with one argument should be marked explicit. [runtime/explicit] [5]
include/onnxruntime/interface/framework/kernel.h|58| You don't need a ; after a } [readability/braces] [4]
include/onnxruntime/interface/framework/kernel.h|72| You don't need a ; after a } [readability/braces] [4]
include/onnxruntime/interface/framework/kernel.h|93| Zero-parameter constructors should not be marked explicit. [runtime/explicit] [5]
include/onnxruntime/interface/framework/kernel.h|94| You don't need a ; after a } [readability/braces] [4]
include/onnxruntime/interface/framework/kernel.h|128| Single-parameter constructors should be marked explicit. [runtime/explicit] [5]
include/onnxruntime/interface/framework/kernel.h|164| Zero-parameter constructors should not be marked explicit. [runtime/explicit] [5]
include/onnxruntime/interface/framework/kernel.h|178| Should have a space between // and comment [whitespace/comments] [4]
include/onnxruntime/interface/framework/kernel.h|214| Lines should be <= 120 characters long [whitespace/line_length] [2]
include/onnxruntime/interface/framework/kernel.h|222| Lines should be <= 120 characters long [whitespace/line_length] [2]
include/onnxruntime/interface/framework/kernel.h|28| Add #include for vector<> [build/include_what_you_use] [4]
include/onnxruntime/interface/framework/kernel.h|39| Add #include for multiplies<> [build/include_what_you_use] [4]
include/onnxruntime/interface/framework/kernel.h|119| Add #include for tuple<> [build/include_what_you_use] [4]
include/onnxruntime/interface/framework/kernel.h|201| Add #include for unique_ptr<> [build/include_what_you_use] [4]
include/onnxruntime/interface/framework/kernel.h|227| Could not find a newline character at the end of the file. [whitespace/ending_newline] [5]
include/onnxruntime/interface/graph/graph.h|63| You don't need a ; after a } [readability/braces] [4]
include/onnxruntime/interface/graph/graph.h|68| Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
include/onnxruntime/interface/graph/graph.h|80| You don't need a ; after a } [readability/braces] [4]
include/onnxruntime/interface/graph/graph.h|146| You don't need a ; after a } [readability/braces] [4]
include/onnxruntime/interface/graph/graph.h|175| You don't need a ; after a } [readability/braces] [4]
include/onnxruntime/interface/graph/graph.h|177| Namespace should be terminated with "// namespace interface" [readability/namespace] [5]
include/onnxruntime/interface/graph/graph.h|179| Namespace should be terminated with "// namespace onnxruntime" [readability/namespace] [5]
include/onnxruntime/interface/provider/provider.h|15| Found C++ system header after other header. Should be: provider.h, c system, c++ system, other. [build/include_order] [4]
include/onnxruntime/interface/provider/provider.h|33| Lines should be <= 120 characters long [whitespace/line_length] [2]
include/onnxruntime/interface/provider/provider.h|34| Lines should be <= 120 characters long [whitespace/line_length] [2]
include/onnxruntime/interface/provider/provider.h|43| Do not indent within a namespace [runtime/indentation_namespace] [4]
include/onnxruntime/interface/provider/provider.h|56| You don't need a ; after a } [readability/braces] [4]
include/onnxruntime/interface/provider/provider.h|58| private: should be indented +1 space inside struct SubGraphDef [whitespace/indent] [3]
include/onnxruntime/interface/provider/provider.h|63| Do not indent within a namespace [runtime/indentation_namespace] [4]
include/onnxruntime/interface/provider/provider.h|64| public: should be indented +1 space inside class ExecutionProvider [whitespace/indent] [3]
include/onnxruntime/interface/provider/provider.h|65| You don't need a ; after a } [readability/braces] [4]
include/onnxruntime/interface/provider/provider.h|69| Lines should be <= 120 characters long [whitespace/line_length] [2]
include/onnxruntime/interface/provider/provider.h|69| Should have a space between // and comment [whitespace/comments] [4]
include/onnxruntime/interface/provider/provider.h|79| Should have a space between // and comment [whitespace/comments] [4]
include/onnxruntime/interface/provider/provider.h|82| Lines should be <= 120 characters long [whitespace/line_length] [2]
include/onnxruntime/interface/provider/provider.h|83| Lines should be <= 120 characters long [whitespace/line_length] [2]
include/onnxruntime/interface/provider/provider.h|88| protected: should be indented +1 space inside class ExecutionProvider [whitespace/indent] [3]
include/onnxruntime/interface/provider/provider.h|94| Namespace should be terminated with "// namespace interface" [readability/namespace] [5]
include/onnxruntime/interface/provider/provider.h|96| Namespace should be terminated with "// namespace onnxruntime" [readability/namespace] [5]
include/onnxruntime/interface/provider/provider.h|81| Add #include for map<> [build/include_what_you_use] [4]
include/onnxruntime/interface/provider/provider.h|90| Add #include for unique_ptr<> [build/include_what_you_use] [4]
include/onnxruntime/interface/provider/provider.h|90| Add #include for vector<> [build/include_what_you_use] [4]
include/onnxruntime/interface/provider/provider.h|91| Add #include for string [build/include_what_you_use] [4]
onnxruntime/core/framework/kernel_registry.cc|46| Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
onnxruntime/core/framework/kernel_registry.cc|47| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/framework/kernel_registry.cc|48| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/framework/kernel_registry.cc|49| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/framework/kernel_registry.cc|110| An else should appear on the same line as the preceding } [whitespace/newline] [4]
onnxruntime/core/framework/kernel_registry.cc|110| If an else has a brace on one side, it should have it on both [readability/braces] [5]
onnxruntime/core/framework/provider_adapter.h|17| Found C++ system header after other header. Should be: provider_adapter.h, c system, c++ system, other. [build/include_order] [4]
onnxruntime/core/framework/provider_adapter.h|22| Single-parameter constructors should be marked explicit. [runtime/explicit] [5]
onnxruntime/core/framework/provider_adapter.h|30| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/framework/provider_adapter.h|31| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/framework/provider_adapter.h|112| Single-parameter constructors should be marked explicit. [runtime/explicit] [5]
onnxruntime/core/framework/provider_adapter.h|181| Single-parameter constructors should be marked explicit. [runtime/explicit] [5]
onnxruntime/core/framework/provider_adapter.h|187| "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4]
onnxruntime/core/framework/provider_adapter.h|201| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/framework/provider_adapter.h|203| Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
onnxruntime/core/framework/provider_adapter.h|204| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/framework/provider_adapter.h|204| "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4]
onnxruntime/core/framework/provider_adapter.h|208| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/framework/provider_adapter.h|214| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/framework/provider_adapter.h|214| "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4]
onnxruntime/core/framework/provider_adapter.h|238| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/framework/provider_adapter.h|238| "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4]
onnxruntime/core/framework/provider_adapter.h|205| Add #include for map<> [build/include_what_you_use] [4]
onnxruntime/core/framework/provider_adapter.h|240| Add #include for vector<> [build/include_what_you_use] [4]
onnxruntime/core/framework/provider_adapter.h|246| Add #include for move [build/include_what_you_use] [4]
onnxruntime/core/graph/graph_view_api_impl.cc|153| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/graph/graph_view_api_impl.cc|184| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/graph/graph_view_api_impl.cc|201| Closing ) should be moved to the previous line [whitespace/parens] [2]
onnxruntime/core/graph/graph_view_api_impl.cc|207| Namespace should be terminated with "// namespace onnxruntime" [readability/namespace] [5]
onnxruntime/core/graph/graph_view_api_impl.cc|155| Add #include for move [build/include_what_you_use] [4]
onnxruntime/core/graph/graph_view_api_impl.cc|188| Add #include for string [build/include_what_you_use] [4]
onnxruntime/core/graph/graph_view_api_impl.cc|190| Add #include for make_unique<> [build/include_what_you_use] [4]
onnxruntime/core/graph/graph_view_api_impl.cc|200| Add #include for vector<> [build/include_what_you_use] [4]
onnxruntime/core/graph/graph_view_api_impl.h|20| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/graph/graph_view_api_impl.h|87| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/graph/graph_view_api_impl.h|100| Namespace should be terminated with "// namespace onnxruntime" [readability/namespace] [5]
onnxruntime/core/graph/graph_view_api_impl.h|73| Add #include for string [build/include_what_you_use] [4]
onnxruntime/core/graph/graph_view_api_impl.h|87| Add #include for move [build/include_what_you_use] [4]
onnxruntime/core/graph/graph_view_api_impl.h|90| Add #include for vector<> [build/include_what_you_use] [4]
onnxruntime/core/graph/graph_view_api_impl.h|92| Add #include for unique_ptr<> [build/include_what_you_use] [4]
onnxruntime/core/optimizer/transpose_optimization/ort_optimizer_api_impl.cc|180| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/optimizer/transpose_optimization/ort_optimizer_api_impl.h|18| Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]
onnxruntime/core/optimizer/transpose_optimization/ort_optimizer_api_impl.h|63| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/optimizer/transpose_optimization/ort_optimizer_api_impl.h|92| Namespace should be terminated with "// namespace onnxruntime" [readability/namespace] [5]
onnxruntime/core/optimizer/transpose_optimization/ort_optimizer_api_impl.h|63| Add #include for move [build/include_what_you_use] [4]
onnxruntime/core/optimizer/transpose_optimization/ort_optimizer_api_impl.h|78| Add #include for unique_ptr<> [build/include_what_you_use] [4]
onnxruntime/core/optimizer/transpose_optimization/ort_optimizer_api_impl.h|84| Add #include for vector<> [build/include_what_you_use] [4]
onnxruntime/core/providers/intree/intree_execution_provider.cc|1| Include the directory when naming header files [build/include_subdir] [4]
onnxruntime/core/providers/intree/intree_execution_provider.cc|14| Missing spaces around << [whitespace/operators] [3]
onnxruntime/core/providers/intree/intree_execution_provider.cc|21| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/providers/intree/intree_execution_provider.cc|23| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/providers/intree/intree_execution_provider.cc|39| private: should be indented +1 space inside struct InTreeCPUAllocator [whitespace/indent] [3]
onnxruntime/core/providers/intree/intree_execution_provider.cc|45| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/providers/intree/intree_execution_provider.cc|48| Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
onnxruntime/core/providers/intree/intree_execution_provider.cc|51| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/providers/intree/intree_execution_provider.cc|56| Missing spaces around << [whitespace/operators] [3]
onnxruntime/core/providers/intree/intree_execution_provider.cc|61| Missing spaces around << [whitespace/operators] [3]
onnxruntime/core/providers/intree/intree_execution_provider.cc|66| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/providers/intree/intree_execution_provider.cc|70| Namespace should be terminated with "// namespace onnxruntime" [readability/namespace] [5]
onnxruntime/core/providers/intree/intree_execution_provider.cc|10| Add #include for multiplies<> [build/include_what_you_use] [4]
onnxruntime/core/providers/intree/intree_execution_provider.cc|46| Add #include for move [build/include_what_you_use] [4]
onnxruntime/core/providers/intree/intree_execution_provider.cc|66| Add #include for string [build/include_what_you_use] [4]
onnxruntime/core/providers/intree/intree_execution_provider.cc|66| Add #include <unordered_map> for unordered_map<> [build/include_what_you_use] [4]
onnxruntime/core/providers/intree/intree_execution_provider.cc|67| Add #include for make_unique<> [build/include_what_you_use] [4]
onnxruntime/core/providers/intree/intree_execution_provider.h|12| public: should be indented +1 space inside class InTreeExecutionProvider [whitespace/indent] [3]
onnxruntime/core/providers/intree/intree_execution_provider.h|13| Single-parameter constructors should be marked explicit. [runtime/explicit] [5]
onnxruntime/core/providers/intree/intree_execution_provider.h|15| private: should be indented +1 space inside class InTreeExecutionProvider [whitespace/indent] [3]
onnxruntime/core/providers/intree/intree_execution_provider.h|20| public: should be indented +1 space inside class InTreeExecutionProviderFactory [whitespace/indent] [3]
onnxruntime/core/providers/intree/intree_execution_provider.h|23| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/providers/intree/intree_execution_provider.h|26| Namespace should be terminated with "// namespace onnxruntime" [readability/namespace] [5]
onnxruntime/core/providers/intree/intree_execution_provider.h|23| Add #include for string [build/include_what_you_use] [4]
onnxruntime/core/providers/intree/intree_execution_provider.h|23| Add #include <unordered_map> for unordered_map<> [build/include_what_you_use] [4]
onnxruntime/core/session/abi_session_options_impl.h|19| Add #include <unordered_map> for unordered_map<> [build/include_what_you_use] [4]
onnxruntime/core/session/custom_ops.cc|683| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/session/custom_ops.h|37| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/session/custom_ops.h|37| Add #include for string [build/include_what_you_use] [4]
onnxruntime/core/session/environment.cc|63| Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
onnxruntime/core/session/environment.cc|75| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/session/environment.cc|78| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/session/environment.cc|78| Using C-style cast. Use reinterpret_cast<void**>(...) instead [readability/casting] [4]
onnxruntime/core/session/environment.cc|96| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/session/onnxruntime_c_api.cc|766| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/session/onnxruntime_c_api.cc|766| Using C-style cast. Use reinterpret_cast<void**>(...) instead [readability/casting] [4]
onnxruntime/core/session/onnxruntime_c_api.cc|767| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/session/onnxruntime_c_api.cc|2369| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/session/onnxruntime_c_api.cc|2370| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/session/onnxruntime_c_api.cc|2387| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/session/ort_apis.h|503| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/session/ort_apis.h|504| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/session/ort_env.cc|114| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/session/ort_env.h|67| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/python/onnxruntime_pybind_state.cc|366| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/python/onnxruntime_pybind_state.cc|367| Missing space before { [whitespace/braces] [5]
onnxruntime/python/onnxruntime_pybind_state.cc|1129| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/python/onnxruntime_pybind_state.cc|1133| Lines should be <= 120 characters long [whitespace/line_length] [2]
samples/c_test/test.cpp|11| Should have a space between // and comment [whitespace/comments] [4]
samples/c_test/test.cpp|15| Lines should be <= 120 characters long [whitespace/line_length] [2]
samples/c_test/test.cpp|28| Lines should be <= 120 characters long [whitespace/line_length] [2]
samples/c_test/test.cpp|36| Using C-style cast. Use reinterpret_cast<void**>(...) instead [readability/casting] [4]
samples/c_test/test.cpp|37| Missing spaces around << [whitespace/operators] [3]
samples/c_test/test.cpp|38| Missing spaces around << [whitespace/operators] [3]
samples/customEP2/custom_ep2.cc|4| Include the directory when naming header files [build/include_subdir] [4]
samples/customEP2/custom_ep2.cc|25| Single-parameter constructors should be marked explicit. [runtime/explicit] [5]
samples/customEP2/custom_ep2.cc|56| Lines should be <= 120 characters long [whitespace/line_length] [2]
samples/customEP2/custom_ep2.cc|58| Lines should be <= 120 characters long [whitespace/line_length] [2]
samples/customEP2/custom_ep2.cc|74| private: should be indented +1 space inside struct CustomCPUAllocator [whitespace/indent] [3]
samples/customEP2/custom_ep2.cc|86| Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
samples/customEP2/custom_ep2.cc|90| Missing spaces around << [whitespace/operators] [3]
samples/customEP2/custom_ep2.cc|95| Missing spaces around << [whitespace/operators] [3]
samples/customEP2/custom_ep2.cc|96| Should have a space between // and comment [whitespace/comments] [4]
samples/customEP2/custom_ep2.cc|104| Lines should be <= 120 characters long [whitespace/line_length] [2]
samples/customEP2/custom_ep2.cc|109| Lines should be <= 120 characters long [whitespace/line_length] [2]
samples/customEP2/custom_ep2.cc|110| Lines should be <= 120 characters long [whitespace/line_length] [2]
samples/customEP2/custom_ep2.cc|117| Missing spaces around << [whitespace/operators] [3]
samples/customEP2/custom_ep2.cc|121| Missing spaces around << [whitespace/operators] [3]
samples/customEP2/custom_ep2.cc|127| public: should be indented +1 space inside class CustomEP2Factory [whitespace/indent] [3]
samples/customEP2/custom_ep2.cc|135| Namespace should be terminated with "// namespace onnxruntime" [readability/namespace] [5]
samples/customEP2/custom_ep2.cc|142| Lines should be <= 120 characters long [whitespace/line_length] [2]
samples/customEP2/custom_ep2.cc|104| Add #include for vector<> [build/include_what_you_use] [4]
samples/customEP2/custom_ep2.cc|142| Add #include for string [build/include_what_you_use] [4]
samples/customEP2/custom_ep2.cc|142| Add #include <unordered_map> for unordered_map<> [build/include_what_you_use] [4]
samples/customEP2/custom_ep2.h|12| public: should be indented +1 space inside class CustomEp2 [whitespace/indent] [3]
samples/customEP2/custom_ep2.h|13| Single-parameter constructors should be marked explicit. [runtime/explicit] [5]
samples/customEP2/custom_ep2.h|19| Lines should be <= 120 characters long [whitespace/line_length] [2]
samples/customEP2/custom_ep2.h|20| private: should be indented +1 space inside class CustomEp2 [whitespace/indent] [3]
samples/customEP2/custom_ep2.h|24| Namespace should be terminated with "// namespace onnxruntime" [readability/namespace] [5]
samples/customEP2/custom_ep2.h|8| Add #include for string [build/include_what_you_use] [4]
samples/customEP2/custom_ep2.h|19| Add #include for unique_ptr<> [build/include_what_you_use] [4]
samples/customEP2/custom_ep2.h|19| Add #include for vector<> [build/include_what_you_use] [4]

Filtered Findings (817149)

build/Debug/CMakeFiles/3.27.7/CompilerIdC/CMakeCCompilerId.c|| No copyright message found. You should have a line: "Copyright [year] " [legal/copyright] [5]
build/Debug/CMakeFiles/3.27.7/CompilerIdC/CMakeCCompilerId.c|50| Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
build/Debug/CMakeFiles/3.27.7/CompilerIdC/CMakeCCompilerId.c|54| Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
build/Debug/CMakeFiles/3.27.7/CompilerIdC/CMakeCCompilerId.c|149| Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
build/Debug/CMakeFiles/3.27.7/CompilerIdC/CMakeCCompilerId.c|154| Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
build/Debug/CMakeFiles/3.27.7/CompilerIdC/CMakeCCompilerId.c|311| Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
build/Debug/CMakeFiles/3.27.7/CompilerIdC/CMakeCCompilerId.c|333| Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
build/Debug/CMakeFiles/3.27.7/CompilerIdC/CMakeCCompilerId.c|399| Lines should be <= 120 characters long [whitespace/line_length] [2]
build/Debug/CMakeFiles/3.27.7/CompilerIdC/CMakeCCompilerId.c|749| Missing space after , [whitespace/comma] [3]
build/Debug/CMakeFiles/3.27.7/CompilerIdC/CMakeCCompilerId.c|754| Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
build/Debug/CMakeFiles/3.27.7/CompilerIdC/CMakeCCompilerId.c|760| Missing space after , [whitespace/comma] [3]
build/Debug/CMakeFiles/3.27.7/CompilerIdC/CMakeCCompilerId.c|767| Missing space after , [whitespace/comma] [3]
build/Debug/CMakeFiles/3.27.7/CompilerIdC/CMakeCCompilerId.c|768| Missing space after , [whitespace/comma] [3]
build/Debug/CMakeFiles/3.27.7/CompilerIdC/CMakeCCompilerId.c|769| Missing space after , [whitespace/comma] [3]
build/Debug/CMakeFiles/3.27.7/CompilerIdC/CMakeCCompilerId.c|778| Missing space after , [whitespace/comma] [3]
build/Debug/CMakeFiles/3.27.7/CompilerIdC/CMakeCCompilerId.c|783| Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
build/Debug/CMakeFiles/3.27.7/CompilerIdC/CMakeCCompilerId.c|789| Missing space after , [whitespace/comma] [3]
build/Debug/CMakeFiles/3.27.7/CompilerIdCXX/CMakeCXXCompilerId.cpp|| No copyright message found. You should have a line: "Copyright [year] " [legal/copyright] [5]
build/Debug/CMakeFiles/3.27.7/CompilerIdCXX/CMakeCXXCompilerId.cpp|50| Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
build/Debug/CMakeFiles/3.27.7/CompilerIdCXX/CMakeCXXCompilerId.cpp|54| Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
build/Debug/CMakeFiles/3.27.7/CompilerIdCXX/CMakeCXXCompilerId.cpp|149| Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
build/Debug/CMakeFiles/3.27.7/CompilerIdCXX/CMakeCXXCompilerId.cpp|154| Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
build/Debug/CMakeFiles/3.27.7/CompilerIdCXX/CMakeCXXCompilerId.cpp|305| Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
build/Debug/CMakeFiles/3.27.7/CompilerIdCXX/CMakeCXXCompilerId.cpp|327| Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
build/Debug/CMakeFiles/3.27.7/CompilerIdCXX/CMakeCXXCompilerId.cpp|397| Lines should be <= 120 characters long [whitespace/line_length] [2]
build/Debug/CMakeFiles/3.27.7/CompilerIdCXX/CMakeCXXCompilerId.cpp|734| Missing space after , [whitespace/comma] [3]
build/Debug/CMakeFiles/3.27.7/CompilerIdCXX/CMakeCXXCompilerId.cpp|739| Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
build/Debug/CMakeFiles/3.27.7/CompilerIdCXX/CMakeCXXCompilerId.cpp|745| Missing space after , [whitespace/comma] [3]
build/Debug/CMakeFiles/3.27.7/CompilerIdCXX/CMakeCXXCompilerId.cpp|752| Missing space after , [whitespace/comma] [3]
build/Debug/CMakeFiles/3.27.7/CompilerIdCXX/CMakeCXXCompilerId.cpp|753| Missing space after , [whitespace/comma] [3]
build/Debug/CMakeFiles/3.27.7/CompilerIdCXX/CMakeCXXCompilerId.cpp|754| Missing space after , [whitespace/comma] [3]
build/Debug/CMakeFiles/3.27.7/CompilerIdCXX/CMakeCXXCompilerId.cpp|763| Missing space after , [whitespace/comma] [3]
build/Debug/CMakeFiles/3.27.7/CompilerIdCXX/CMakeCXXCompilerId.cpp|768| Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
build/Debug/CMakeFiles/3.27.7/CompilerIdCXX/CMakeCXXCompilerId.cpp|774| Missing space after , [whitespace/comma] [3]
build/Debug/CMakeFiles/3.27.7/CompilerIdCXX/CMakeCXXCompilerId.cpp|831| { should almost always be at the end of the previous line [whitespace/braces] [4]
build/Debug/_deps/abseil_cpp-src/absl/algorithm/algorithm.h|22| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_ALGORITHM_ALGORITHM_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/algorithm/algorithm.h|159| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_ALGORITHM_ALGORITHM_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/algorithm/algorithm.h|107| Add #include for forward [build/include_what_you_use] [4]
build/Debug/_deps/abseil_cpp-src/absl/algorithm/container.h|40| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_ALGORITHM_CONTAINER_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/algorithm/container.h|1774| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_ALGORITHM_CONTAINER_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/algorithm/equal_benchmark.cc|34| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
build/Debug/_deps/abseil_cpp-src/absl/base/attributes.h|34| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_ATTRIBUTES_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/attributes.h|835| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_ATTRIBUTES_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/call_once.h|25| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_CALL_ONCE_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/call_once.h|219| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_CALL_ONCE_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/call_once_test.cc|17| is an unapproved C++11 header. [build/c++11] [5]
... (Too many findings. Dropped some findings)

Annotations

Check warning on line 11 in include/onnxruntime/core/framework/allocator.h

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] include/onnxruntime/core/framework/allocator.h#L11

 Found C++ system header after other header. Should be: allocator.h, c system, c++ system, other.  [build/include_order] [4]
Raw output
include/onnxruntime/core/framework/allocator.h:11:  Found C++ system header after other header. Should be: allocator.h, c system, c++ system, other.  [build/include_order] [4]

Check warning on line 12 in include/onnxruntime/core/framework/allocator.h

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] include/onnxruntime/core/framework/allocator.h#L12

 Found C++ system header after other header. Should be: allocator.h, c system, c++ system, other.  [build/include_order] [4]
Raw output
include/onnxruntime/core/framework/allocator.h:12:  Found C++ system header after other header. Should be: allocator.h, c system, c++ system, other.  [build/include_order] [4]

Check warning on line 17 in include/onnxruntime/core/framework/node_compute_info.h

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] include/onnxruntime/core/framework/node_compute_info.h#L17

 Namespace should be terminated with "// namespace onnxruntime"  [readability/namespace] [5]
Raw output
include/onnxruntime/core/framework/node_compute_info.h:17:  Namespace should be terminated with "// namespace onnxruntime"  [readability/namespace] [5]

Check warning on line 49 in include/onnxruntime/core/framework/op_kernel_context.h

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] include/onnxruntime/core/framework/op_kernel_context.h#L49

 Should have a space between // and comment  [whitespace/comments] [4]
Raw output
include/onnxruntime/core/framework/op_kernel_context.h:49:  Should have a space between // and comment  [whitespace/comments] [4]

Check warning on line 18 in include/onnxruntime/core/session/environment.h

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] include/onnxruntime/core/session/environment.h#L18

 Single-parameter constructors should be marked explicit.  [runtime/explicit] [5]
Raw output
include/onnxruntime/core/session/environment.h:18:  Single-parameter constructors should be marked explicit.  [runtime/explicit] [5]

Check warning on line 20 in include/onnxruntime/core/session/environment.h

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] include/onnxruntime/core/session/environment.h#L20

 Lines should be <= 120 characters long  [whitespace/line_length] [2]
Raw output
include/onnxruntime/core/session/environment.h:20:  Lines should be <= 120 characters long  [whitespace/line_length] [2]

Check warning on line 27 in include/onnxruntime/core/session/environment.h

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] include/onnxruntime/core/session/environment.h#L27

 Lines should be <= 120 characters long  [whitespace/line_length] [2]
Raw output
include/onnxruntime/core/session/environment.h:27:  Lines should be <= 120 characters long  [whitespace/line_length] [2]

Check warning on line 113 in include/onnxruntime/core/session/environment.h

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] include/onnxruntime/core/session/environment.h#L113

 Lines should be <= 120 characters long  [whitespace/line_length] [2]
Raw output
include/onnxruntime/core/session/environment.h:113:  Lines should be <= 120 characters long  [whitespace/line_length] [2]

Check warning on line 126 in include/onnxruntime/core/session/environment.h

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] include/onnxruntime/core/session/environment.h#L126

 Add #include <string> for string  [build/include_what_you_use] [4]
Raw output
include/onnxruntime/core/session/environment.h:126:  Add #include <string> for string  [build/include_what_you_use] [4]

Check warning on line 126 in include/onnxruntime/core/session/environment.h

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] include/onnxruntime/core/session/environment.h#L126

 Add #include <unordered_map> for unordered_map<>  [build/include_what_you_use] [4]
Raw output
include/onnxruntime/core/session/environment.h:126:  Add #include <unordered_map> for unordered_map<>  [build/include_what_you_use] [4]

Check warning on line 4516 in include/onnxruntime/core/session/onnxruntime_c_api.h

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] include/onnxruntime/core/session/onnxruntime_c_api.h#L4516

 Lines should be <= 120 characters long  [whitespace/line_length] [2]
Raw output
include/onnxruntime/core/session/onnxruntime_c_api.h:4516:  Lines should be <= 120 characters long  [whitespace/line_length] [2]

Check warning on line 4518 in include/onnxruntime/core/session/onnxruntime_c_api.h

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] include/onnxruntime/core/session/onnxruntime_c_api.h#L4518

 Lines should be <= 120 characters long  [whitespace/line_length] [2]
Raw output
include/onnxruntime/core/session/onnxruntime_c_api.h:4518:  Lines should be <= 120 characters long  [whitespace/line_length] [2]

Check warning on line 25 in include/onnxruntime/interface/common/data_types.h

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] include/onnxruntime/interface/common/data_types.h#L25

 Namespace should be terminated with "// namespace interface"  [readability/namespace] [5]
Raw output
include/onnxruntime/interface/common/data_types.h:25:  Namespace should be terminated with "// namespace interface"  [readability/namespace] [5]

Check warning on line 27 in include/onnxruntime/interface/common/data_types.h

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] include/onnxruntime/interface/common/data_types.h#L27

 Could not find a newline character at the end of the file.  [whitespace/ending_newline] [5]
Raw output
include/onnxruntime/interface/common/data_types.h:27:  Could not find a newline character at the end of the file.  [whitespace/ending_newline] [5]

Check warning on line 12 in include/onnxruntime/interface/framework/Tensor.h

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] include/onnxruntime/interface/framework/Tensor.h#L12

 Could not find a newline character at the end of the file.  [whitespace/ending_newline] [5]
Raw output
include/onnxruntime/interface/framework/Tensor.h:12:  Could not find a newline character at the end of the file.  [whitespace/ending_newline] [5]

Check warning on line 32 in include/onnxruntime/interface/framework/kernel.h

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] include/onnxruntime/interface/framework/kernel.h#L32

 Should have a space between // and comment  [whitespace/comments] [4]
Raw output
include/onnxruntime/interface/framework/kernel.h:32:  Should have a space between // and comment  [whitespace/comments] [4]

Check warning on line 33 in include/onnxruntime/interface/framework/kernel.h

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] include/onnxruntime/interface/framework/kernel.h#L33

 You don't need a ; after a }  [readability/braces] [4]
Raw output
include/onnxruntime/interface/framework/kernel.h:33:  You don't need a ; after a }  [readability/braces] [4]

Check warning on line 33 in include/onnxruntime/interface/framework/kernel.h

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] include/onnxruntime/interface/framework/kernel.h#L33

 Constructors callable with one argument should be marked explicit.  [runtime/explicit] [5]
Raw output
include/onnxruntime/interface/framework/kernel.h:33:  Constructors callable with one argument should be marked explicit.  [runtime/explicit] [5]

Check warning on line 58 in include/onnxruntime/interface/framework/kernel.h

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] include/onnxruntime/interface/framework/kernel.h#L58

 You don't need a ; after a }  [readability/braces] [4]
Raw output
include/onnxruntime/interface/framework/kernel.h:58:  You don't need a ; after a }  [readability/braces] [4]

Check warning on line 72 in include/onnxruntime/interface/framework/kernel.h

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] include/onnxruntime/interface/framework/kernel.h#L72

 You don't need a ; after a }  [readability/braces] [4]
Raw output
include/onnxruntime/interface/framework/kernel.h:72:  You don't need a ; after a }  [readability/braces] [4]

Check warning on line 93 in include/onnxruntime/interface/framework/kernel.h

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] include/onnxruntime/interface/framework/kernel.h#L93

 Zero-parameter constructors should not be marked explicit.  [runtime/explicit] [5]
Raw output
include/onnxruntime/interface/framework/kernel.h:93:  Zero-parameter constructors should not be marked explicit.  [runtime/explicit] [5]

Check warning on line 94 in include/onnxruntime/interface/framework/kernel.h

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] include/onnxruntime/interface/framework/kernel.h#L94

 You don't need a ; after a }  [readability/braces] [4]
Raw output
include/onnxruntime/interface/framework/kernel.h:94:  You don't need a ; after a }  [readability/braces] [4]

Check warning on line 128 in include/onnxruntime/interface/framework/kernel.h

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] include/onnxruntime/interface/framework/kernel.h#L128

 Single-parameter constructors should be marked explicit.  [runtime/explicit] [5]
Raw output
include/onnxruntime/interface/framework/kernel.h:128:  Single-parameter constructors should be marked explicit.  [runtime/explicit] [5]

Check warning on line 164 in include/onnxruntime/interface/framework/kernel.h

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] include/onnxruntime/interface/framework/kernel.h#L164

 Zero-parameter constructors should not be marked explicit.  [runtime/explicit] [5]
Raw output
include/onnxruntime/interface/framework/kernel.h:164:  Zero-parameter constructors should not be marked explicit.  [runtime/explicit] [5]

Check warning on line 178 in include/onnxruntime/interface/framework/kernel.h

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] include/onnxruntime/interface/framework/kernel.h#L178

 Should have a space between // and comment  [whitespace/comments] [4]
Raw output
include/onnxruntime/interface/framework/kernel.h:178:  Should have a space between // and comment  [whitespace/comments] [4]