Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RegexFullMatch operator #18002

Merged
merged 9 commits into from
Jan 11, 2024
Merged

RegexFullMatch operator #18002

merged 9 commits into from
Jan 11, 2024

Conversation

adityagoel4512
Copy link
Contributor

Description

Motivation and Context

Closes #17594.

@adityagoel4512 adityagoel4512 marked this pull request as ready for review November 2, 2023 10:16
@adityagoel4512 adityagoel4512 mentioned this pull request Nov 10, 2023
Merged
@thiagocrepaldi
Copy link
Contributor

@adityagoel4512 any update on this? ORT 1.17 release is coming soon :)

@adityagoel4512
Copy link
Contributor Author

@adityagoel4512 any update on this? ORT 1.17 release is coming soon :)

Waiting on a review round/CI pipelines to be run by a maintainer.

yuslepukhin
yuslepukhin previously approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@yuslepukhin yuslepukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@justinchuby
Copy link
Contributor

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,ONNX Runtime Web CI Pipeline,Windows ARM64 QNN CI Pipeline

@justinchuby
Copy link
Contributor

/azp run Windows CPU CI Pipeline,Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline,Windows x64 QNN CI Pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,onnxruntime-binary-size-checks-ci-pipeline

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 9 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 8 pipeline(s).

@yuslepukhin
Copy link
Member

/azp run MacOS CI Pipeline, Windows CPU CI Pipeline, Windows GPU CI Pipeline, Windows GPU TensorRT CI Pipeline, ONNX Runtime Web CI Pipeline, onnxruntime-python-checks-ci-pipeline

@yuslepukhin
Copy link
Member

/azp run Linux CPU CI Pipeline, Linux CPU Minimal Build E2E CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline, Linux Nuphar CI Pipeline, Linux OpenVINO CI Pipeline, Linux QNN CI Pipeline, Windows ARM64 QNN CI Pipeline

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@yuslepukhin
Copy link
Member

/azp run onnxruntime-binary-size-checks-ci-pipeline

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

yuslepukhin
yuslepukhin previously approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@yuslepukhin yuslepukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@justinchuby justinchuby added this to the 1.17 milestone Jan 10, 2024
@yuslepukhin
Copy link
Member

Changes to docs required:
REgFullMatchDocs.txt

@yuslepukhin
Copy link
Member

WASM build tests fail, will try to find out what is going on:

2024-01-10T19:49:29.2164985Z 1: �[32m10 01 2024 19:49:29.214:INFO [karma-server]: �[39mKarma v6.4.1 server started at http://localhost:9876/
2024-01-10T19:49:29.2165843Z 1: �[32m10 01 2024 19:49:29.215:INFO [launcher]: �[39mLaunching browsers ChromeHeadlessTest with concurrency unlimited
2024-01-10T19:49:29.2184593Z 1: �[32m10 01 2024 19:49:29.218:INFO [launcher]: �[39mStarting browser ChromeHeadless
2024-01-10T19:49:33.6317399Z 1: �[32m10 01 2024 19:49:33.631:INFO [Chrome Headless 120.0.6099.199 (Linux x86_64)]: �[39mConnected on socket wzGXfitT0_D6Qz5sAAAB with id 54354320
2024-01-10T19:49:35.0661766Z 1: Chrome Headless 120.0.6099.199 (Linux x86_64): Executed 0 of 1 SUCCESS (0 secs / 0 secs)
2024-01-10T19:49:37.4509002Z 1: �[1A�[2KERROR: 'worker sent an error! http://localhost:9876/base/onnxruntime_test_all.worker.js:172: Uncaught RuntimeError: memory access out of bounds'
2024-01-10T19:49:37.4509827Z 1: Chrome Headless 120.0.6099.199 (Linux x86_64): Executed 0 of 1 SUCCESS (0 secs / 0 secs)
2024-01-10T19:49:37.4510388Z 1: �[1A�[2KChrome Headless 120.0.6099.199 (Linux x86_64) ERROR
2024-01-10T19:49:37.4510675Z 1: Uncaught [object ErrorEvent]
2024-01-10T19:49:37.4510958Z 1: at onnxruntime_test_all.js:6674:4
2024-01-10T19:49:37.4511290Z 1: Chrome Headless 120.0.6099.199 (Linux x86_64): Executed 0 of 1 ERROR (0 secs / 0 secs)

yuslepukhin
yuslepukhin previously approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@yuslepukhin yuslepukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@yuslepukhin
Copy link
Member

/azp run Windows ARM64 QNN CI Pipeline,Windows x64 QNN CI Pipeline,Windows CPU CI Pipeline,Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline,ONNX Runtime Web CI Pipeline,Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline

@yuslepukhin
Copy link
Member

/azp run Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,orttraining-amd-gpu-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,onnxruntime-python-checks-ci-pipeline,onnxruntime-binary-size-checks-ci-pipeline,Android CI Pipeline

@yuslepukhin
Copy link
Member

/azp run iOS CI Pipeline,ONNX Runtime React Native CI Pipeline

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 9 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 10 pipeline(s).

yuslepukhin
yuslepukhin approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@yuslepukhin yuslepukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@yuslepukhin
Copy link
Member

/azp run Windows ARM64 QNN CI Pipeline,Windows x64 QNN CI Pipeline,Windows CPU CI Pipeline,Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline,ONNX Runtime Web CI Pipeline,Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline

@yuslepukhin
Copy link
Member

/azp run Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,orttraining-amd-gpu-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,onnxruntime-python-checks-ci-pipeline,onnxruntime-binary-size-checks-ci-pipeline,Android CI Pipeline

@yuslepukhin
Copy link
Member

/azp run iOS CI Pipeline,ONNX Runtime React Native CI Pipeline

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 9 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 10 pipeline(s).

@yuslepukhin yuslepukhin merged commit d8962d6 into microsoft:main Jan 11, 2024
72 of 74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xadupre xadupre xadupre left review comments

@edgchen1 edgchen1 edgchen1 left review comments

@yuslepukhin yuslepukhin yuslepukhin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.17
Development

Successfully merging this pull request may close these issues.

Add compute kernel for RegexFullMatch
8 participants
@adityagoel4512 @thiagocrepaldi @justinchuby @yuslepukhin @edgchen1 @xadupre @YUNQIUGUO @jywu-msft