Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TensorRT EP] Fix cmake install #17923

Merged
merged 1 commit into from
Oct 16, 2023
Merged

[TensorRT EP] Fix cmake install #17923

merged 1 commit into from
Oct 16, 2023

Conversation

chilo-ms
Copy link
Contributor

@chilo-ms chilo-ms commented Oct 12, 2023

We removed tensorrt_provider_factory.h in the PR.
Need to remove the copy of this file when cmake install.

@chilo-ms chilo-ms requested a review from jywu-msft October 12, 2023 21:06
@gedoensmax
Copy link
Contributor

Not really point of this PR, but have you throught about addinng onnxruntime_perf_test to the installed targets ? It's a binary that is perfect for checking out which EP is the perfect choice for someone.

@chilo-ms
Copy link
Contributor Author

chilo-ms commented Oct 13, 2023

Not really point of this PR, but have you throught about addinng onnxruntime_perf_test to the installed targets ? It's a binary that is perfect for checking out which EP is the perfect choice for someone.

That's a good point and i always use onnxruntime_perf_test to start running the EP.
Once thing i need to check is whether the workflow of release packages is using this CMake install.
Actually, other people have similar request to include the onnxruntime_perf_test in release package. But right now we are not decided yet.

@chilo-ms chilo-ms merged commit 8abaa7b into main Oct 16, 2023
89 of 91 checks passed
@chilo-ms chilo-ms deleted the chi/trt_cmake_fix branch October 16, 2023 16:16
jchen351 pushed a commit that referenced this pull request Oct 18, 2023
We removed tensorrt_provider_factory.h in the
[PR](#17617).
Need to remove the copy of this file when cmake install.
kleiti pushed a commit to kleiti/onnxruntime that referenced this pull request Mar 22, 2024
We removed tensorrt_provider_factory.h in the
[PR](microsoft#17617).
Need to remove the copy of this file when cmake install.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants