Fix build break with cuda 12.2 #17922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snnn
reviewed
Oct 12, 2023
onnxruntime/contrib_ops/cuda/bert/flash_attention/flash_fwd_launch_template.h
Outdated
Show resolved
Hide resolved
jchen351
previously approved these changes
Oct 12, 2023
tianleiwu
reviewed
Oct 12, 2023
onnxruntime/contrib_ops/cuda/bert/flash_attention/flash_fwd_launch_template.h
Outdated
Show resolved
Hide resolved
aciddelgado
previously approved these changes
Oct 12, 2023
|
Please don't merge the PR. It fails a local test. |
yufenglee
force-pushed
the
yufeng/build_break_122
branch
from
6b213eb to
8f3a3ae
Compare
tianleiwu
approved these changes
Oct 13, 2023
jchen351
pushed a commit
that referenced
this pull request
Oct 18, 2023
### Description <!-- Describe your changes. --> nvcc 12.2 crashes while building onnxruntime/onnxruntime/contrib_ops/cuda/bert/flash_attention/flash_fwd_* for SM<8.0. nvcc 18.8 works though. It should be a bug in nvcc 12.2. This PR excludes building flashattention for arch < 800.
tianleiwu
pushed a commit
that referenced
this pull request
Oct 31, 2023
### Description <!-- Describe your changes. --> nvcc 12.2 crashes while building onnxruntime/onnxruntime/contrib_ops/cuda/bert/flash_attention/flash_fwd_* for SM<8.0. nvcc 18.8 works though. It should be a bug in nvcc 12.2. This PR excludes building flashattention for arch < 800.
tianleiwu
removed
triage:approved
kleiti
pushed a commit
to kleiti/onnxruntime
that referenced
this pull request
Mar 22, 2024
### Description <!-- Describe your changes. --> nvcc 12.2 crashes while building onnxruntime/onnxruntime/contrib_ops/cuda/bert/flash_attention/flash_fwd_* for SM<8.0. nvcc 18.8 works though. It should be a bug in nvcc 12.2. This PR excludes building flashattention for arch < 800.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
nvcc 12.2 crashes while building onnxruntime/onnxruntime/contrib_ops/cuda/bert/flash_attention/flash_fwd_* for SM<8.0. nvcc 18.8 works though. It should be a bug in nvcc 12.2.
This PR excludes building flashattention for arch < 800.