update emsdk to 3.1.47 [don't merge - perf regression] #17916
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to update cgmanifest.json by cgmanifests\generate_cgmanifest.py |
fs-eire
reviewed
Nov 22, 2023
| @@ -225,6 +225,7 @@ else() | |||
| "SHELL:-s EXPORT_ALL=0" | |||
| "SHELL:-s VERBOSE=0" | |||
| "SHELL:-s FILESYSTEM=0" | |||
| "SHELL:-s INCOMING_MODULE_JS_API=[preRun,locateFile,arguments,onExit,wasmMemory,buffer,instantiateWasm,mainScriptUrlOrBlob]" | |||
There was a problem hiding this comment.
do we need to use the same list for ort-web to onnxruntime_test_all ?
There was a problem hiding this comment.
"mainScriptUrlOrBlob", for example, is not used by onnxruntime_test_all but it is required by ort-wasm. So perhaps need to figure out the full list of INCOMING_MODULE_JS_API per target.
There was a problem hiding this comment.
I can trim things down once ci is happy.
mszhanyi
approved these changes
Nov 27, 2023
snnn
reviewed
Nov 27, 2023
There was a problem hiding this comment.
Please also update https://github.com/microsoft/onnxruntime/blob/main/cgmanifests/generated/cgmanifest.json with this new commit id.
guschmue
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.