Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QNN EP] Fix index-out-of-bounds bug in Slice builder when initializer is shared #17905

Merged
merged 7 commits into from
Oct 13, 2023

Conversation

adrianlizarraga
Copy link
Contributor

@adrianlizarraga adrianlizarraga commented Oct 12, 2023

Description

There's an index-out-of-bounds bug that is triggered when a Slice operator shares an initializer with another operator that is processed first. In this case, QNN EP fails to properly initialize a raw_starts (or raw_ends) vector, which is later indexed by a call to SliceOp::PrepareForComputeHelper().

Motivation and Context

Fix bug that blocks #17764

yuslepukhin
yuslepukhin previously approved these changes Oct 12, 2023
@adrianlizarraga adrianlizarraga merged commit 3b69d9b into main Oct 13, 2023
91 checks passed
@adrianlizarraga adrianlizarraga deleted the adrianl/qnn-bug-slice-shared-initializer branch October 13, 2023 20:46
jchen351 pushed a commit that referenced this pull request Oct 18, 2023
…r is shared (#17905)

### Description
There's an index-out-of-bounds bug that is triggered when a Slice
operator shares an initializer with another operator that is processed
first. In this case, QNN EP fails to properly initialize a `raw_starts`
(or `raw_ends`) vector, which is later indexed by a call to
`SliceOp::PrepareForComputeHelper()`.


### Motivation and Context
Fix bug that blocks #17764
kleiti pushed a commit to kleiti/onnxruntime that referenced this pull request Mar 22, 2024
…r is shared (microsoft#17905)

### Description
There's an index-out-of-bounds bug that is triggered when a Slice
operator shares an initializer with another operator that is processed
first. In this case, QNN EP fails to properly initialize a `raw_starts`
(or `raw_ends`) vector, which is later indexed by a call to
`SliceOp::PrepareForComputeHelper()`.


### Motivation and Context
Fix bug that blocks microsoft#17764
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants