[QNN EP] Handle rank 3 InstanceNormalization with N != 1 #17897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianlizarraga
commented
Oct 12, 2023
onnxruntime/core/providers/qnn/builder/opbuilder/instance_norm_op_builder.cc
Outdated
Show resolved
Hide resolved
HectorSVC
reviewed
Oct 12, 2023
onnxruntime/core/providers/qnn/builder/opbuilder/instance_norm_op_builder.cc
Outdated
Show resolved
Hide resolved
adrianlizarraga
deleted the
adrianl/qnn-htp-instance-norm-rank3-improve
branch
jchen351
pushed a commit
that referenced
this pull request
Oct 18, 2023
### Description The QNN HTP backend does not support rank 3 InstanceNorm if the batch size is not 1. To work around this limitation, QNN EP can wrap a rank 4 QNN InstanceNorm op with Reshapes (with the H dim set to 1). ### Motivation and Context Enable support for more models.
kleiti
pushed a commit
to kleiti/onnxruntime
that referenced
this pull request
Mar 22, 2024
…7897) ### Description The QNN HTP backend does not support rank 3 InstanceNorm if the batch size is not 1. To work around this limitation, QNN EP can wrap a rank 4 QNN InstanceNorm op with Reshapes (with the H dim set to 1). ### Motivation and Context Enable support for more models.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The QNN HTP backend does not support rank 3 InstanceNorm if the batch size is not 1. To work around this limitation, QNN EP can wrap a rank 4 QNN InstanceNorm op with Reshapes (with the H dim set to 1).
Motivation and Context
Enable support for more models.