Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WebNN EP] Add a duplicate entry to support new "dataType" #17841

Merged
merged 2 commits into from
Oct 12, 2023
Merged

[WebNN EP] Add a duplicate entry to support new "dataType" #17841

merged 2 commits into from
Oct 12, 2023

Conversation

Honry
Copy link
Contributor

@Honry Honry commented Oct 9, 2023

WebNN spec renames "type" as "dataType" at
webmachinelearning/webnn#464, add a duplicate entry for "dataType" in order to workaround the compatibility issue.

@Honry
[WebNN EP] Add a duplicate entry to support new "dataType"
d566f96 
WebNN spec renames "type" as "dataType" at
webmachinelearning/webnn#464,
add a duplicate entry for "dataType" in order to workaround
the compatibility issue.
@Honry
Copy link
Contributor Author

Honry commented Oct 9, 2023

@fdwr, @guschmue, PTAL, thanks!

@guschmue
Copy link
Contributor

guschmue commented Oct 9, 2023

/azp run ONNX Runtime Web CI Pipeline

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@guschmue
Copy link
Contributor

guschmue commented Oct 9, 2023

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

@guschmue
Copy link
Contributor

guschmue commented Oct 9, 2023

/azp run Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed

@azure-pipelines
Copy link

Azure Pipelines successfully started running 6 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 9 pipeline(s).

fdwr
fdwr approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Wanming.

@fdwr
Copy link
Contributor

fdwr commented Oct 10, 2023

/azp run ONNX Runtime Web CI Pipeline

@fdwr
Copy link
Contributor

fdwr commented Oct 10, 2023

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

@fdwr
Copy link
Contributor

fdwr commented Oct 10, 2023

/azp run Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 6 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 9 pipeline(s).

@guschmue
Copy link
Contributor

/azp run Windows x64 QNN CI Pipeline

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@fdwr fdwr merged commit b3cab55 into microsoft:main Oct 12, 2023
62 checks passed
kleiti pushed a commit to kleiti/onnxruntime that referenced this pull request Mar 22, 2024
@Honry @kleiti
[WebNN EP] Add a duplicate entry to support new "dataType" (microsoft…
231f928 
…#17841)

WebNN spec renames "type" as "dataType" at
webmachinelearning/webnn#464, add a duplicate
entry for "dataType" in order to workaround the compatibility issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fdwr fdwr fdwr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Honry @guschmue @fdwr