Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix runtime installation error #17828

Merged
merged 3 commits into from
Oct 7, 2023
Merged

Fix runtime installation error #17828

merged 3 commits into from
Oct 7, 2023

Conversation

MistEO
Copy link
Contributor

@MistEO MistEO commented Oct 7, 2023

This seems to be a typo that causes .dll files to be placed into the lib folder on Windows.

For reference, I searched for other installation and they all pointed to ${CMAKE_INSTALL_BINDIR}
image

MistEO referenced this pull request in MaaAssistantArknights/MaaDeps Oct 7, 2023
@MistEO
Copy link
Contributor Author

MistEO commented Oct 7, 2023

@microsoft-github-policy-service agree

@snnn
Copy link
Member

snnn commented Oct 7, 2023

/azp run Linux CPU CI Pipeline, Linux CPU Minimal Build E2E CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline, Linux OpenVINO CI Pipeline, Linux QNN CI Pipeline, MacOS CI Pipeline, ONNX Runtime Web CI Pipeline

@snnn
Copy link
Member

snnn commented Oct 7, 2023

/azp run Windows ARM64 QNN CI Pipeline, Windows CPU CI Pipeline, Windows GPU CI Pipeline, Windows GPU TensorRT CI Pipeline, Windows x64 QNN CI Pipeline, onnxruntime-binary-size-checks-ci-pipeline, orttraining-linux-ci-pipeline, orttraining-linux-gpu-ci-pipeline, orttraining-ortmodule-distributed

@azure-pipelines
Copy link

Azure Pipelines successfully started running 8 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 9 pipeline(s).

@snnn snnn merged commit faf9a0f into microsoft:main Oct 7, 2023
62 checks passed
kleiti pushed a commit to kleiti/onnxruntime that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants