Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement dft(20) #17821

Merged
merged 9 commits into from
Dec 19, 2023
Merged

Implement dft(20) #17821

merged 9 commits into from
Dec 19, 2023

Conversation

liqunfu
Copy link
Contributor

@liqunfu liqunfu commented Oct 6, 2023

Description

dft is updated in opset20. implement it in ort

Motivation and Context

this is for ort 1.17.0 release

Fixes #17723

Signed-off-by: Liqun Fu <[email protected]>
@liqunfu liqunfu added this to the 1.17 milestone Oct 6, 2023
@justinchuby justinchuby changed the title implement dft(20) Implement dft(20) Oct 17, 2023
Signed-off-by: Liqun Fu <[email protected]>
Signed-off-by: Liqun Fu <[email protected]>
Signed-off-by: Liqun Fu <[email protected]>
Signed-off-by: Liqun Fu <[email protected]>
@justinchuby
Copy link
Contributor

justinchuby commented Nov 9, 2023

I would make sure ORT behaves correctly when axis=0. Currently the output shape is not right (CPU EP).

Signed-off-by: Liqun Fu <[email protected]>
@liqunfu
Copy link
Contributor Author

liqunfu commented Nov 9, 2023

I would make sure ORT behaves correctly when axis=0. Currently the output shape is not right (CPU EP).

@justinchuby do we have test for this case. All onnx test cases are passing.

@liqunfu
Copy link
Contributor Author

liqunfu commented Nov 25, 2023

I would make sure ORT behaves correctly when axis=0. Currently the output shape is not right (CPU EP).

@justinchuby do we have test for this case. All onnx test cases are passing.

I extended test cases to axis=0 for since version being 20.

@liqunfu liqunfu closed this Nov 28, 2023
@liqunfu liqunfu reopened this Nov 28, 2023
@justinchuby justinchuby merged commit 32fcf73 into main Dec 19, 2023
106 of 111 checks passed
@justinchuby justinchuby deleted the liqun/dft20 branch December 19, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add compute kernel for DFT(20)
3 participants