[js/webgpu] allow to specify callback for profiling data #17820
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axinging
reviewed
Oct 7, 2023
axinging
reviewed
Oct 7, 2023
| // eslint-disable-next-line no-console | ||
| console.log(`[profiling] kernel "${kernelId}|${kernelName}" ${inputShapes}${outputShapes}execution time: ${ | ||
| endTime - startTime} ns`); | ||
| if (this.backend.env.webgpu.profiling?.ondata) { |
There was a problem hiding this comment.
Default startTime is always 0. And any use case for profilingTimeBase?
if (typeof this.backend.profilingTimeBase === 'undefined') {
this.backend.profilingTimeBase = startTimeU64;
}
const startTime = Number(startTimeU64 - this.backend.profilingTimeBase);
const endTime = Number(endTimeU64 - this.backend.profilingTimeBase);
There was a problem hiding this comment.
backend.profilingTimeBase is designed to log the time of the start time of the first completed kernel (startTime64). By using this, the startTime and endTime can be relatively small to fit into int53.
fs-eire
commented
Oct 10, 2023
guschmue
previously approved these changes
Oct 11, 2023
|
Close this one. Use #18732 instead. The reason why I create a new PR is because somehow the check "license/cla" is not triggered for this PR and seems there is no way to manually trigger it unless create a new PR. |
fs-eire
added a commit
that referenced
this pull request
Dec 7, 2023
### Description **This PR is a replacement of #17820.** allow to specify callback for profiling data *Previous*: ```js ort.env.webgpu.profilingMode = 'default'; // enable profiling // profiling data will output to console. ``` *Now*: ```js ort.env.webgpu.profiling = { mode: 'default'; // enable profiling ondata: (data) => { // .. process the profiling data } }; //for each kernel, "ondata" will be called once. only output to console if ondata is not specified. ```
siweic0
pushed a commit
to siweic0/onnxruntime-web
that referenced
this pull request
May 9, 2024
…8732) ### Description **This PR is a replacement of microsoft#17820.** allow to specify callback for profiling data *Previous*: ```js ort.env.webgpu.profilingMode = 'default'; // enable profiling // profiling data will output to console. ``` *Now*: ```js ort.env.webgpu.profiling = { mode: 'default'; // enable profiling ondata: (data) => { // .. process the profiling data } }; //for each kernel, "ondata" will be called once. only output to console if ondata is not specified. ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
allow to specify callback for profiling data
Previous:
Now: