Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Pad's quantization #17807

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Fix Pad's quantization #17807

merged 1 commit into from
Oct 9, 2023

Conversation

wschin
Copy link
Contributor

@wschin wschin commented Oct 5, 2023

Fix #17760. Upstream exporter creates empty string as Pad's 3rd input and the quantization tool 1) considers that as a valid tensor name and 2) adds corresponding invalid quantization nodes. This PR adds a condition check to make quantization tool working.

@wschin wschin marked this pull request as ready for review October 5, 2023 23:23
@wschin wschin requested a review from chenfucn October 5, 2023 23:32
@wschin wschin added the quantization issues related to quantization label Oct 5, 2023
@wschin wschin self-assigned this Oct 5, 2023
@wschin wschin added the merge on green This PR can be merged when the CI is green. Please merge. label Oct 7, 2023
Copy link
Contributor

@chenfucn chenfucn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, especially the test case explaining all rationales.

@wschin wschin merged commit 60f19ab into main Oct 9, 2023
91 checks passed
@wschin wschin deleted the wechi/fix-qpad branch October 9, 2023 05:09
kleiti pushed a commit to kleiti/onnxruntime that referenced this pull request Mar 22, 2024
Fix microsoft#17760. Upstream exporter creates empty string as Pad's 3rd input
and the quantization tool 1) considers that as a valid tensor name and
2) adds corresponding invalid quantization nodes. This PR adds a
condition check to make quantization tool working.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge on green This PR can be merged when the CI is green. Please merge. quantization issues related to quantization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Naming conflict when quantizing models with Pad nodes
2 participants