Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add API for NPU Device Selection in the DML EP #17612

Merged
merged 36 commits into from
Oct 11, 2023
Merged

Add API for NPU Device Selection in the DML EP #17612

merged 36 commits into from
Oct 11, 2023

Conversation

nums11
Copy link
Contributor

@nums11 nums11 commented Sep 19, 2023

No description provided.

@PatriceVignola
Copy link
Contributor

PatriceVignola commented Oct 7, 2023 •
edited by smk2007
Loading

@nums11 Is there a plan to expose this API through python as well? Maybe through DML EP options (similar to how settings are passed to the CUDA EP options at session creation). #Resolved

martinb35
martinb35 requested changes Oct 9, 2023
View reviewed changes
cmake/onnxruntime_providers.cmake Outdated Show resolved Hide resolved
onnxruntime/core/providers/dml/dml_provider_factory.cc Show resolved Hide resolved
onnxruntime/core/providers/dml/dml_provider_factory.cc Outdated Show resolved Hide resolved
onnxruntime/core/providers/dml/dml_provider_factory.cc Outdated Show resolved Hide resolved
onnxruntime/test/perftest/ort_test_session.cc Outdated Show resolved Hide resolved
@smk2007 smk2007 marked this pull request as ready for review October 9, 2023 23:34
@smk2007
Copy link
Member

smk2007 commented Oct 10, 2023

Yep should be updated now!

In reply to: 1751574490

@smk2007 smk2007 merged commit b8f373b into main Oct 11, 2023
87 of 91 checks passed
@smk2007 smk2007 deleted the npu_with_dml_ep branch October 11, 2023 21:53
smk2007 pushed a commit that referenced this pull request Oct 11, 2023
@nums11
Add API for NPU Device Selection in the DML EP (#17612)
d6f449d 
Co-authored-by: Sheil Kumar <[email protected]>
kleiti pushed a commit to kleiti/onnxruntime that referenced this pull request Mar 22, 2024
@nums11 @kleiti
Add API for NPU Device Selection in the DML EP (microsoft#17612)
7177e32 
Co-authored-by: Sheil Kumar <[email protected]>
@mengniwang95 mengniwang95 mentioned this pull request Nov 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smk2007 smk2007 smk2007 left review comments

@fdwr fdwr fdwr left review comments

@martinb35 martinb35 martinb35 approved these changes

@PatriceVignola PatriceVignola PatriceVignola approved these changes

@linnealovespie linnealovespie Awaiting requested review from linnealovespie

@zhangxiang1993 zhangxiang1993 Awaiting requested review from zhangxiang1993

@sivileri sivileri Awaiting requested review from sivileri

@wchao1115 wchao1115 Awaiting requested review from wchao1115

@shawnhar shawnhar Awaiting requested review from shawnhar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nums11 @PatriceVignola @smk2007 @fdwr @martinb35