Avoid get_logger overriding root logger level
#17569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BowenBao
force-pushed
the
bowbao/logger_level
branch
from
ba8971b to
8edcf6c
Compare
thiagocrepaldi
approved these changes
Sep 18, 2023
You are right, Turns out to be pretty hacky involving handler and more details since formatter is not exposed on logger level for individual logger. Leaving as is for formatting in this PR. ref https://stackoverflow.com/questions/11581794/how-do-i-change-the-format-of-a-python-log-message-on-a-per-logger-basis |
kleiti
pushed a commit
to kleiti/onnxruntime
that referenced
this pull request
Mar 22, 2024
### Description Instead, set level to DEBUG for the logger returned. ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> Otherwise, this function call overrides root logger level setting, which affects logging facility of other python packages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead, set level to DEBUG for the logger returned.
Motivation and Context
Otherwise, this function call overrides root logger level setting, which affects logging facility of other python packages.