[js/webgpu]FusedConv #17503
Closed
[js/webgpu]FusedConv #17503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -500,6 +502,8 @@ std::unique_ptr<KernelRegistry> RegisterKernels() { | |||
| BuildKernelCreateInfo<ONNX_OPERATOR_TYPED_KERNEL_CLASS_NAME(kJsExecutionProvider, kMSInternalNHWCDomain, 1, float, GlobalAveragePool)>, | |||
| BuildKernelCreateInfo<ONNX_OPERATOR_TYPED_KERNEL_CLASS_NAME(kJsExecutionProvider, kMSInternalNHWCDomain, 1, float, GlobalMaxPool)>, | |||
|
|
|||
| BuildKernelCreateInfo<ONNX_CPU_OPERATOR_TYPED_MS_KERNEL(kJsExecutionProvider, kMSDomain, 1, float, FusedConv)>, | |||
There was a problem hiding this comment.
Specifying the domain, kMSDomain, is not required when using ONNX_CPU_OPERATOR_TYPED_MS_KERNEL macro. Only name, version, type, builder, etc. are required. Is it a CPU operator?
I think you want to use the class name declared in line number 243.
| { | ||
| "name": "conv without bias addition A", | ||
| "operator": "Conv", | ||
| "attributes": [{ "name": "kernel_shape", "data": [2, 2], "type": "ints" }], |
There was a problem hiding this comment.
Are you planning to add activation attribute to this test case also?
| class FusedConv : public Conv<T, is_channels_last> { | ||
| public: | ||
| explicit FusedConv(const OpKernelInfo& info) : Conv<T, is_channels_last>(info) { | ||
| ORT_ENFORCE(info.GetAttr<std::string>("activation", &(this->conv_attrs_.activation)).IsOK()); |
There was a problem hiding this comment.
Setting this attribute here will not pass the value to JSEP kernel because JSEP kernel is already created in the base class constructor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context