Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QNN EP] Add more op unit tests (fix Clip, TopK, Tile) #17457

Merged
merged 26 commits into from
Sep 20, 2023
Merged

[QNN EP] Add more op unit tests (fix Clip, TopK, Tile) #17457

merged 26 commits into from
Sep 20, 2023

Conversation

adrianlizarraga
Copy link
Contributor

@adrianlizarraga adrianlizarraga commented Sep 7, 2023 •
edited
Loading

Description

Adds more operator unit tests (all op types should now have at least 1 unit test):

  • Reshape
  • Flatten
  • Squeeze
  • Unsqueeze
  • Gemm
  • Clip
    • Enable QDQ Clip on HTP backend (when not optimized away by L1 ClipQuantFusion optimizer)
    • Add support for 16-bit QDQ Clip to ClipQuantFusion optimizer
  • Split
  • Topk
    • Enable QDQ TopK on HTP backend
  • Tile
    • Enable QDQ Tile on HTP backend

Motivation and Context

Increase QNN operator support and test coverage.

@adrianlizarraga adrianlizarraga changed the title [QNN EP] Add more op unit tests [QNN EP] Add more op unit tests (fix Clip, TopK, Tile) Sep 20, 2023
@adrianlizarraga adrianlizarraga marked this pull request as ready for review September 20, 2023 09:51
HectorSVC
HectorSVC previously approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@HectorSVC HectorSVC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

HectorSVC
HectorSVC approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@HectorSVC HectorSVC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@adrianlizarraga adrianlizarraga merged commit c55da45 into main Sep 20, 2023
91 checks passed
@adrianlizarraga adrianlizarraga deleted the adrianl/qnn-more-op-unit-tests-2 branch September 20, 2023 21:31
kleiti pushed a commit to kleiti/onnxruntime that referenced this pull request Mar 22, 2024
@adrianlizarraga @kleiti
[QNN EP] Add more op unit tests (fix Clip, TopK, Tile) (microsoft#17457)
ca00804 
### Description
Adds more operator unit tests (all op types should now have at least 1
unit test):
- [x] Reshape
- [x] Flatten
- [x] Squeeze
- [x] Unsqueeze
- [x] Gemm
- [x] Clip
- Enable QDQ Clip on HTP backend (when not optimized away by L1
ClipQuantFusion optimizer)
  - Add support for 16-bit QDQ Clip to ClipQuantFusion optimizer
- [x] Split
- [x] Topk
  - Enable QDQ TopK on HTP backend
- [x] Tile
  - Enable QDQ Tile on HTP backend



### Motivation and Context
Increase QNN operator support and test coverage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HectorSVC HectorSVC HectorSVC approved these changes

@jywu-msft jywu-msft Awaiting requested review from jywu-msft

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrianlizarraga @HectorSVC