Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve tunable verbose log #17328

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Improve tunable verbose log #17328

merged 1 commit into from
Oct 31, 2023

Conversation

cloudhan
Copy link
Contributor 

2023-08-29 07:55:17.342831564 [V:onnxruntime:Default, tunable.h:255 FindFastestImpl] finding fastest for onnxruntime::rocm::tunable::blas::internal::StridedBatchedGemmTunableOp<__half, ck::tensor_layout::gemm::RowMajor, ck::tensor_layout::gemm::RowMajor>(NN_512_64_512_B768)
2023-08-29 07:55:17.401587241 [V:onnxruntime:Default, tunable.h:282 FindFastestImpl] ├──found better instance, new best id=0, old id=-1. 0.530955ms, 100 iters.
2023-08-29 07:55:18.050736248 [V:onnxruntime:Default, tunable.h:275 FindFastestImpl] ├──skip slow instance id=9
2023-08-29 07:55:18.322117986 [V:onnxruntime:Default, tunable.h:275 FindFastestImpl] ├──skip slow instance id=13
...
2023-08-29 07:55:20.411862520 [V:onnxruntime:Default, tunable.h:275 FindFastestImpl] ├──skip slow instance id=48
2023-08-29 07:55:20.499956010 [V:onnxruntime:Default, tunable.h:275 FindFastestImpl] ├──skip slow instance id=50
2023-08-29 07:55:20.509966465 [V:onnxruntime:Default, tunable.h:275 FindFastestImpl] ├──skip slow instance id=51
2023-08-29 07:55:20.509979039 [V:onnxruntime:Default, tunable.h:289 FindFastestImpl] └──found fastest with id=0 for onnxruntime::rocm::tunable::blas::internal::StridedBatchedGemmTunableOp<__half, ck::tensor_layout::gemm::RowMajor, ck::tensor_layout::gemm::RowMajor>(NN_512_64_512_B768)

@cloudhan cloudhan requested review from mindest and PeixuanZuo August 29, 2023 09:05
@cloudhan cloudhan mentioned this pull request Sep 1, 2023
Merged
@cloudhan cloudhan force-pushed the guangyunhan/imporve-tunable-verbose-log branch from 9af8f0c to 8d26593 Compare October 9, 2023 06:17
mindest
mindest approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@mindest mindest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

onnxruntime/core/framework/tunable.h Show resolved Hide resolved
@mindest mindest changed the title Imporve tunable verbose log Improve tunable verbose log Oct 24, 2023
@cloudhan cloudhan force-pushed the guangyunhan/imporve-tunable-verbose-log branch from 8d26593 to dedf495 Compare October 26, 2023 07:55
@cloudhan cloudhan merged commit 08dce54 into main Oct 31, 2023
85 of 89 checks passed
@cloudhan cloudhan deleted the guangyunhan/imporve-tunable-verbose-log branch October 31, 2023 05:10
kleiti pushed a commit to kleiti/onnxruntime that referenced this pull request Mar 22, 2024
@cloudhan @kleiti
Improve tunable verbose log (microsoft#17328)
8d4184e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mindest mindest mindest approved these changes

@PeixuanZuo PeixuanZuo Awaiting requested review from PeixuanZuo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cloudhan @mindest