Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QNN EP] Add support for GatherElements #15966

Merged
merged 21 commits into from
Aug 19, 2024

Conversation

adrianlizarraga
Copy link
Contributor

@adrianlizarraga adrianlizarraga commented May 16, 2023

Description

  • Adds support for the GatherElements operator to QNN EP.
  • Adds GatherElements to QDQ quantizer tool.

Motivation and Context

Enable more models to run on QNN EP.

@adrianlizarraga adrianlizarraga marked this pull request as draft May 16, 2023 18:30
@adrianlizarraga
Copy link
Contributor Author

adrianlizarraga commented May 17, 2023

@HectorSVC @jywu-msft I made this into a draft because of the many inconsistencies with the gather ops.

  • QNN Gather ops do not support negative indices (supported by ONNX)
  • QNN GatherElements output does not match ONNX or pyTorch when axis != 0
  • QNN GatherNd output does not match ONNX when batch_dims != 0

These need to be addressed before this can be merged.

@adrianlizarraga adrianlizarraga changed the title [QNN EP] Add support for GatherElements and GatherND [QNN EP] Add support for GatherElements Aug 9, 2024
@adrianlizarraga adrianlizarraga marked this pull request as ready for review August 13, 2024 04:36
@adrianlizarraga adrianlizarraga merged commit a22cc07 into main Aug 19, 2024
97 of 98 checks passed
@adrianlizarraga adrianlizarraga deleted the adrianl/qnn-support-gatherelems-gathernd branch August 19, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants