added suggestion

microsoft · Nov 22, 2023 · fa9f545 · fa9f545
1 parent a4ff61c
commit fa9f545
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/js/common/lib/backend.ts b/js/common/lib/backend.ts
@@ -50,7 +50,7 @@ export interface TrainingSessionHandler extends SessionHandler {
       options: InferenceSession.RunOptions): Promise<SessionHandler.ReturnType>;
 
   getParametersSize(trainableOnly: boolean): Promise<number>;
-  loadParametersBuffer(array: Float32Array, trainableOnly: boolean): Promise<void>;
+  loadParametersBuffer(array: Uint8Array, trainableOnly: boolean): Promise<void>;
   getContiguousParameters(trainableOnly: boolean): Promise<OnnxValue>;
 }
 

diff --git a/js/web/lib/wasm/wasm-training-core-impl.ts b/js/web/lib/wasm/wasm-training-core-impl.ts
@@ -406,8 +406,8 @@ export const loadParametersBuffer =
   const locationAsString = 'cpu';
 
   // allocates & copies JavaScript buffer to WASM heap
-  const bufferCount = getParametersSize(trainingSessionId, trainableOnly);
   const bufferByteLength = buffer.length;
+  const bufferCount = bufferByteLength / 4;
   const bufferOffset = wasm._malloc(bufferByteLength);
   wasm.HEAPU8.set(buffer, bufferOffset);