Skip to content

Commit

Permalink
Address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
raoanag committed Nov 18, 2023
1 parent 0e28411 commit ea4d7bc
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ namespace Dml
{
GraphTransformer::GraphTransformer(
const std::string& name,
const onnxruntime::IExecutionProvider* provider
const onnxruntime::IExecutionProvider* provider
) : onnxruntime::GraphTransformer(name),
m_providerImpl(static_cast<const ExecutionProvider*>(provider)->GetImpl())
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

namespace Dml
{
class ExecutionProviderImpl;
class ExecutionProviderImpl;

Check warning on line 13 in onnxruntime/core/providers/dml/DmlExecutionProvider/src/GraphTransformer.h

View workflow job for this annotation

GitHub Actions / cpplint

[cpplint] onnxruntime/core/providers/dml/DmlExecutionProvider/src/GraphTransformer.h#L13

Do not indent within a namespace [runtime/indentation_namespace] [4]
Raw output
onnxruntime/core/providers/dml/DmlExecutionProvider/src/GraphTransformer.h:13:  Do not indent within a namespace  [runtime/indentation_namespace] [4]

// Applies transforms to a Lotus graph. The graph transformer is responsible for setting the execution provider
// on the graph nodes which DML supports.
Expand All @@ -19,7 +19,7 @@ namespace Dml
public:
GraphTransformer(
const std::string& name,

Check warning on line 21 in onnxruntime/core/providers/dml/DmlExecutionProvider/src/GraphTransformer.h

View workflow job for this annotation

GitHub Actions / cpplint

[cpplint] onnxruntime/core/providers/dml/DmlExecutionProvider/src/GraphTransformer.h#L21

Add #include <string> for string [build/include_what_you_use] [4]
Raw output
onnxruntime/core/providers/dml/DmlExecutionProvider/src/GraphTransformer.h:21:  Add #include <string> for string  [build/include_what_you_use] [4]
const onnxruntime::IExecutionProvider* provider
const onnxruntime::IExecutionProvider* provider
);

private:
Expand All @@ -28,7 +28,7 @@ namespace Dml
private:
void PerformOperatorFusion(onnxruntime::Graph* graph, bool isMcdmDevice, bool* modified) const;

const ExecutionProviderImpl* m_providerImpl = nullptr;
const ExecutionProviderImpl* m_providerImpl = nullptr;
};

} // namespace Dml

0 comments on commit ea4d7bc

Please sign in to comment.