Skip to content

Commit

Permalink
Additional lintrunner pass - disregarding C++ linter pass
Browse files Browse the repository at this point in the history
Linter is giving me conflicting things to do from the C++ pass in MSFT CI. Defaulting to just getting the Python pass to run
  • Loading branch information
TedThemistokleous committed Oct 30, 2023
1 parent e8c5c59 commit 8f1c83d
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 9 deletions.
10 changes: 5 additions & 5 deletions include/onnxruntime/core/session/onnxruntime_c_api.h
Original file line number Diff line number Diff line change
Expand Up @@ -598,11 +598,11 @@ typedef struct OrtTensorRTProviderOptions {
* \see OrtApi::SessionOptionsAppendExecutionProvider_MIGraphX
*/
typedef struct OrtMIGraphXProviderOptions {
int device_id; // hip device id.
int migraphx_fp16_enable; // enable MIGraphX FP16 precision. Default 0 = false, nonzero = true
int migraphx_int8_enable; // enable MIGraphX INT8 precision. Default 0 = false, nonzero = true
int migraphx_use_native_calibration_table; // MIGraphx INT8 cal table. Default 0 = false, noznero = true
const char* migraphx_int8_calibration_table_name; // MIGraphx INT8 calibration table name
int device_id; // hip device id.
int migraphx_fp16_enable; // enable MIGraphX FP16 precision. Default 0 = false, nonzero = true
int migraphx_int8_enable; // enable MIGraphX INT8 precision. Default 0 = false, nonzero = true

Check warning on line 603 in include/onnxruntime/core/session/onnxruntime_c_api.h

View workflow job for this annotation

GitHub Actions / Lint C++

[cpplint] reported by reviewdog 🐶 Lines should be <= 120 characters long [whitespace/line_length] [2] Raw Output: include/onnxruntime/core/session/onnxruntime_c_api.h:603: Lines should be <= 120 characters long [whitespace/line_length] [2]
int migraphx_use_native_calibration_table; // MIGraphx INT8 cal table. Default 0 = false, noznero = true

Check warning on line 604 in include/onnxruntime/core/session/onnxruntime_c_api.h

View workflow job for this annotation

GitHub Actions / Lint C++

[cpplint] reported by reviewdog 🐶 Lines should be <= 120 characters long [whitespace/line_length] [2] Raw Output: include/onnxruntime/core/session/onnxruntime_c_api.h:604: Lines should be <= 120 characters long [whitespace/line_length] [2]
const char* migraphx_int8_calibration_table_name; // MIGraphx INT8 calibration table name
} OrtMIGraphXProviderOptions;

/** \brief OpenVINO Provider Options
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
// TODO: find a better way to share this
#include "core/providers/rocm/rocm_stream_handle.h"


#if defined(_MSC_VER)
#pragma warning(disable : 4244 4245)
#elif __GNUC__
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
// TODO: find a better way to share this
// #include "core/providers/cuda/rocm_stream_handle.h"


namespace onnxruntime {

namespace migraphx_env_vars {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,7 @@ struct MIGraphX_Provider : Provider {
info.target_device = "gpu";
info.fp16_enable = options.migraphx_fp16_enable;
info.int8_enable = options.migraphx_int8_enable;
info.int8_calibration_table_name = options.migraphx_int8_calibration_table_name == nullptr ? "" :
options.migraphx_int8_calibration_table_name;
info.int8_calibration_table_name = options.migraphx_int8_calibration_table_name == nullptr ? "" : options.migraphx_int8_calibration_table_name;

Check warning on line 51 in onnxruntime/core/providers/migraphx/migraphx_provider_factory.cc

View workflow job for this annotation

GitHub Actions / Lint C++

[cpplint] reported by reviewdog 🐶 Lines should be <= 120 characters long [whitespace/line_length] [2] Raw Output: onnxruntime/core/providers/migraphx/migraphx_provider_factory.cc:51: Lines should be <= 120 characters long [whitespace/line_length] [2]
info.int8_use_native_calibration_table = options.migraphx_use_native_calibration_table != 0;
return std::make_shared<MIGraphXProviderFactory>(info);
}
Expand Down

0 comments on commit 8f1c83d

Please sign in to comment.