address comments

microsoft · Feb 2, 2024 · 71dd18b · 71dd18b
1 parent ebeb628
commit 71dd18b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/js/web/lib/wasm/jsep/webgpu/ops/3rd-party/conv_backprop_mm_webgpu.ts b/js/web/lib/wasm/jsep/webgpu/ops/3rd-party/conv_backprop_mm_webgpu.ts
@@ -130,7 +130,7 @@ const conv2dTransposeCommonSnippet =
       return ${type}(0.0);
       `;
 
-      const applyActivation = getActivationSnippet(attributes, type, 'f32');
+      const applyActivation = getActivationSnippet(attributes, type);
       const userCode = `
   fn mm_readA(batch: i32, row : i32, colIn : i32) -> ${type} {
     ${isChannelsLast ? sampleA : sampleW}

diff --git a/js/web/lib/wasm/jsep/webgpu/ops/fuse-utils.ts b/js/web/lib/wasm/jsep/webgpu/ops/fuse-utils.ts
@@ -16,7 +16,7 @@ export interface InternalActivationAttributes {
 }
 
 export const getActivationSnippet =
-    (attributes: InternalActivationAttributes, valueType: string, baseType: string): string => {
+    (attributes: InternalActivationAttributes, valueType: string, baseType = 'f32'): string => {
       switch (attributes.activation) {
         case 'Relu':
           return `value = max(value, ${valueType}(0.0));`;