Skip to content

Commit

Permalink
typo and lint
Browse files Browse the repository at this point in the history
  • Loading branch information
Yi Zhang committed Dec 23, 2024
1 parent ee98190 commit 52d099a
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 6 deletions.
2 changes: 1 addition & 1 deletion onnxruntime/core/providers/cpu/fp16/fp16_activations.h
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ struct LeakyRelu<MLFloat16> : public ElementWiseRangedTransform<MLFloat16> {
// TODO Add the following activations:
// MlasTanhActivation,
// MlasLogisticActivation,
// MlasClipActivation,
// MlasClipActivation,
// Once it's added, please update TestNhwcConvReluClipFusion_FP16
// in xnnpack_basic_test.cc
// to enable outputs verification for Clip activation.
Expand Down
6 changes: 3 additions & 3 deletions onnxruntime/test/providers/cpu/nn/conv_fp16_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -56,12 +56,12 @@ void TestConvFp16Op(const ConvOpAndTestAttributes& attributes,
} else if (attributes.domain == onnxruntime::kMSInternalNHWCDomain) {
op = "Conv";
tester = std::make_unique<OpTester>(op, opset, attributes.domain);
} else if (attributes.domain == onnxruntime::kOnnxDomain) {
} else if (attributes.domain == onnxruntime::kOnnxDomain) {
op = "FusedConv";
} else {
ORT_THROW("Unsupported domain: ", attributes.domain);
}

tester->AddAttribute("activation", attributes.activation);

if (!attributes.activation_parameters.empty()) {
Expand Down Expand Up @@ -1176,7 +1176,7 @@ TEST(ConvFp16Test, Pointwise_Relu) {
};
run_test(attrs);
attrs.domain = kMSInternalNHWCDomain;
attrs.excluded_providers = {kCpuExecutionProvider};
attrs.excluded_providers = {kCpuExecutionProvider};
run_test(attrs);
}

Expand Down
3 changes: 1 addition & 2 deletions onnxruntime/test/providers/xnnpack/xnnpack_basic_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,6 @@ TEST(XnnpackEP, TestNhwcConvReluFusion_FP16) {
params.graph_verifier = &verify;

auto ep = DefaultXnnpackExecutionProvider();
// So far, CPU EP doensn't support Fp16 Conv fusion, so verify_outputs is skipped.
RunAndVerifyOutputsWithEP(ort_model_path, "TestNhwcConvReluFusion_FP16", std::move(ep), feeds, params);
};

Expand Down Expand Up @@ -172,7 +171,7 @@ TEST(XnnpackEP, TestNhwcConvReluClipFusion_FP16) {
params.graph_verifier = &verify;

auto ep = DefaultXnnpackExecutionProvider();
// So far, CPU EP doensn't support Fp16 Conv fusion, so verify_outputs is skipped.
// So far, CPU EP doesn't support Fp16 Conv fusion, so verify_outputs is skipped.
RunAndVerifyOutputsWithEP(ort_model_path, "TestNhwcConvReluClipFusion_FP16", std::move(ep), feeds, params, {}, false);
}
#endif
Expand Down

0 comments on commit 52d099a

Please sign in to comment.