Skip to content

Commit

Permalink
Address PR comments
Browse files Browse the repository at this point in the history
  • Loading branch information
skottmckay committed Jun 27, 2024
1 parent db5e27c commit 26cead4
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ Status GemmOpBuilder::AddToModelBuilderImpl(ModelBuilder& model_builder, const N
// ML Program MatMul supports N-D input, however we don't use the 'K' or 'N' values calculated below for it
// so we don't need to update b0 or b1.
} else {
// we only support 2D input for all other combination
// we only support 2D input for all other combinations
b0 = b_shape[0];
b1 = b_shape[1];
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -906,7 +906,7 @@ Status ModelBuilder::SaveModel() {

#if defined(COREML_ENABLE_MLPROGRAM)
if (create_ml_program_) {
// we need to jump through some hurdles to get the model path the ML Program load wants.
// we need to jump through some hoops to get the model path the ML Program load wants.
std::string tmp_model_path = model_output_path_ + "/tmp/model.mlmodel";
CreateEmptyFile(tmp_model_path);

Expand Down

0 comments on commit 26cead4

Please sign in to comment.