Skip to content

Commit

Permalink
Delete path.h (#21211)
Browse files Browse the repository at this point in the history
### Description
Delete path.h and replace all occurrences of onnxruntime::Path with
std::filesystem::path.
Previously we couldn't use C++17's std::filesystem because it was not
supported in iOS 12(which was released in 2018). Now we dropped the
support for iOS 12.

### Motivation and Context
To simplify code. For example, if an EP wants to use the Path class, now
it can directly use it without going through a wrapper. And the standard
implementation can handle various path types better. (We didn't take
much consideration on UNC path, "/" as a path separator on Windows,
etc).
  • Loading branch information
snnn authored Jul 4, 2024
1 parent 40d4b2e commit 07c4291
Show file tree
Hide file tree
Showing 22 changed files with 25 additions and 734 deletions.
2 changes: 1 addition & 1 deletion include/onnxruntime/core/graph/graph.h
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,12 @@
#include "core/common/gsl.h"

#include "core/common/common.h"
#include "core/common/path_string.h"
#include "core/common/const_pointer_container.h"
#if !defined(ORT_MINIMAL_BUILD)
#include "core/common/inlined_containers.h"
#endif
#include "core/common/inlined_containers_fwd.h"
#include "core/common/path.h"
#include "core/common/span_utils.h"
#include "core/common/status.h"
#include "core/common/logging/logging.h"
Expand Down
308 changes: 0 additions & 308 deletions onnxruntime/core/common/path.cc

This file was deleted.

Loading

0 comments on commit 07c4291

Please sign in to comment.