Skip to content

Commit

Permalink
Fix lint error
Browse files Browse the repository at this point in the history
  • Loading branch information
zesongw committed Dec 19, 2023
1 parent cb56495 commit 01f91d5
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -276,10 +276,10 @@ Status ConvOpBuilder::AddToModelBuilderImpl(ModelBuilder& model_builder, const N
options.set("filterLayout", emscripten::val("ihwo"));
}
}
emscripten::val filter = model_builder.GetOperand(weight);
if (op_type == "Conv")
emscripten::val filter = model_builder.GetOperand(weight_name);
if (op_type == "Conv") {
output = model_builder.GetBuilder().call<emscripten::val>("conv2d", input, filter, options);
else {
} else {
emscripten::val x_zero_point = emscripten::val::null();
emscripten::val w_zero_point = emscripten::val::null();
if (input_defs.size() >= 3) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
#include "core/providers/webnn/builders/model_builder.h"
#include "core/providers/webnn/builders/op_builder_factory.h"

#include "base_op_builder.h"
#include "core/providers/webnn/builders/impl/base_op_builder.h"

namespace onnxruntime {
namespace webnn {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
#include "core/providers/webnn/builders/model_builder.h"
#include "core/providers/webnn/builders/op_builder_factory.h"

#include "base_op_builder.h"
#include "core/providers/webnn/builders/impl/base_op_builder.h"

namespace onnxruntime {
namespace webnn {
Expand Down
2 changes: 2 additions & 0 deletions onnxruntime/core/providers/webnn/builders/model_builder.cc
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@
#include "core/providers/common.h"
#include "core/providers/shared/utils/utils.h"

#include <utility>

Check warning on line 17 in onnxruntime/core/providers/webnn/builders/model_builder.cc

View workflow job for this annotation

GitHub Actions / Lint C++

[cpplint] reported by reviewdog 🐶 Found C++ system header after other header. Should be: model_builder.h, c system, c++ system, other. [build/include_order] [4] Raw Output: onnxruntime/core/providers/webnn/builders/model_builder.cc:17: Found C++ system header after other header. Should be: model_builder.h, c system, c++ system, other. [build/include_order] [4]

namespace onnxruntime {
namespace webnn {

Expand Down

0 comments on commit 01f91d5

Please sign in to comment.