Add GQA support for ROCm #31244
lint.yml
on: pull_request
Optional Lint
34s
Python format
3m 27s
Lint C++
23m 41s
Lint JavaScript
24s
Annotations
2 errors and 18 warnings
Python format
Process completed with exit code 1.
|
Lint C++
reviewdog: Too many results (annotations) in diff.
You may miss some annotations due to GitHub limitation for annotation created by logging command.
Please check GitHub Actions log console to see all results.
Limitation:
- 10 warning annotations and 10 error annotations per step
- 50 annotations per job (sum of annotations from all the steps)
- 50 annotations per run (separate from the job annotations, these annotations aren't created by users)
Source: https://github.com/orgs/community/discussions/26680#discussioncomment-3252835
|
Optional Lint:
onnxruntime/contrib_ops/rocm/bert/group_query_attention.cu#L363
[misspell] reported by reviewdog 🐶
"lenghts" is a misspelling of "lengths"
Raw Output:
./onnxruntime/contrib_ops/rocm/bert/group_query_attention.cu:363:47: "lenghts" is a misspelling of "lengths"
|
Optional Lint:
onnxruntime/contrib_ops/cuda/bert/rotary_embedding_impl.cu#L119
[misspell] reported by reviewdog 🐶
"cannoical" is a misspelling of "canonical"
Raw Output:
./onnxruntime/contrib_ops/cuda/bert/rotary_embedding_impl.cu:119:16: "cannoical" is a misspelling of "canonical"
|
Python format
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/toolchain@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Python format
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Python format
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Python format
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Python format
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Python format
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Lint C++:
onnxruntime/contrib_ops/rocm/bert/group_query_attention.cu#L14
[cpplint] reported by reviewdog 🐶
Include the directory when naming header files [build/include_subdir] [4]
Raw Output:
onnxruntime/contrib_ops/rocm/bert/group_query_attention.cu:14: Include the directory when naming header files [build/include_subdir] [4]
|
Lint C++:
onnxruntime/contrib_ops/rocm/bert/group_query_attention.cu#L17
[cpplint] reported by reviewdog 🐶
Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]
Raw Output:
onnxruntime/contrib_ops/rocm/bert/group_query_attention.cu:17: Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]
|
Lint C++:
onnxruntime/contrib_ops/rocm/bert/group_query_attention.cu#L18
[cpplint] reported by reviewdog 🐶
Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]
Raw Output:
onnxruntime/contrib_ops/rocm/bert/group_query_attention.cu:18: Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]
|
Lint C++:
onnxruntime/contrib_ops/rocm/bert/group_query_attention.cu#L19
[cpplint] reported by reviewdog 🐶
Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]
Raw Output:
onnxruntime/contrib_ops/rocm/bert/group_query_attention.cu:19: Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]
|
Lint C++:
onnxruntime/contrib_ops/rocm/bert/group_query_attention.cu#L423
[cpplint] reported by reviewdog 🐶
Lines should be <= 120 characters long [whitespace/line_length] [2]
Raw Output:
onnxruntime/contrib_ops/rocm/bert/group_query_attention.cu:423: Lines should be <= 120 characters long [whitespace/line_length] [2]
|
Lint C++:
onnxruntime/contrib_ops/rocm/bert/group_query_attention.cu#L424
[cpplint] reported by reviewdog 🐶
Lines should be <= 120 characters long [whitespace/line_length] [2]
Raw Output:
onnxruntime/contrib_ops/rocm/bert/group_query_attention.cu:424: Lines should be <= 120 characters long [whitespace/line_length] [2]
|
Lint C++:
onnxruntime/contrib_ops/rocm/bert/group_query_attention.cu#L425
[cpplint] reported by reviewdog 🐶
Lines should be <= 120 characters long [whitespace/line_length] [2]
Raw Output:
onnxruntime/contrib_ops/rocm/bert/group_query_attention.cu:425: Lines should be <= 120 characters long [whitespace/line_length] [2]
|
Lint C++:
onnxruntime/contrib_ops/rocm/bert/group_query_attention.cu#L426
[cpplint] reported by reviewdog 🐶
Lines should be <= 120 characters long [whitespace/line_length] [2]
Raw Output:
onnxruntime/contrib_ops/rocm/bert/group_query_attention.cu:426: Lines should be <= 120 characters long [whitespace/line_length] [2]
|
Lint C++:
onnxruntime/contrib_ops/rocm/bert/group_query_attention.cu#L427
[cpplint] reported by reviewdog 🐶
Lines should be <= 120 characters long [whitespace/line_length] [2]
Raw Output:
onnxruntime/contrib_ops/rocm/bert/group_query_attention.cu:427: Lines should be <= 120 characters long [whitespace/line_length] [2]
|
Lint C++:
onnxruntime/contrib_ops/rocm/bert/group_query_attention.cu#L428
[cpplint] reported by reviewdog 🐶
Lines should be <= 120 characters long [whitespace/line_length] [2]
Raw Output:
onnxruntime/contrib_ops/rocm/bert/group_query_attention.cu:428: Lines should be <= 120 characters long [whitespace/line_length] [2]
|