Skip to content

Add implementation for ScatterND #26635

Add implementation for ScatterND

Add implementation for ScatterND #26635

Triggered via pull request February 27, 2024 15:21
@xaduprexadupre
synchronize #19540
xadupre:f16
Status Failure
Total duration 23m 39s
Artifacts

lint.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 17 warnings
Python format
Process completed with exit code 1.
Lint C++
reviewdog: Too many results (annotations) in diff. You may miss some annotations due to GitHub limitation for annotation created by logging command. Please check GitHub Actions log console to see all results. Limitation: - 10 warning annotations and 10 error annotations per step - 50 annotations per job (sum of annotations from all the steps) - 50 annotations per run (separate from the job annotations, these annotations aren't created by users) Source: https://github.community/t5/GitHub-Actions/Maximum-number-of-annotations-that-can-be-created-using-GitHub/m-p/39085
Optional Lint: onnxruntime/core/providers/cuda/tensor/scatter_nd.h#L52
[misspell] reported by reviewdog 🐶 "garuantees" is a misspelling of "guarantees" Raw Output: ./onnxruntime/core/providers/cuda/tensor/scatter_nd.h:52:72: "garuantees" is a misspelling of "guarantees"
Python format
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/toolchain@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Python format
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Python format
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Python format
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Python format
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Python format
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Lint C++: onnxruntime/core/providers/cuda/cuda_execution_provider.cc#L2026
[cpplint] reported by reviewdog 🐶 Lines should be <= 120 characters long [whitespace/line_length] [2] Raw Output: onnxruntime/core/providers/cuda/cuda_execution_provider.cc:2026: Lines should be <= 120 characters long [whitespace/line_length] [2]
Lint C++: onnxruntime/core/providers/cuda/cuda_execution_provider.cc#L2154
[cpplint] reported by reviewdog 🐶 Lines should be <= 120 characters long [whitespace/line_length] [2] Raw Output: onnxruntime/core/providers/cuda/cuda_execution_provider.cc:2154: Lines should be <= 120 characters long [whitespace/line_length] [2]
Lint C++: onnxruntime/core/providers/cuda/tensor/scatter_nd.cc#L122
[cpplint] reported by reviewdog 🐶 Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2] Raw Output: onnxruntime/core/providers/cuda/tensor/scatter_nd.cc:122: Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
Lint C++: onnxruntime/core/providers/cuda/tensor/scatter_nd.cc#L124
[cpplint] reported by reviewdog 🐶 Lines should be <= 120 characters long [whitespace/line_length] [2] Raw Output: onnxruntime/core/providers/cuda/tensor/scatter_nd.cc:124: Lines should be <= 120 characters long [whitespace/line_length] [2]
Lint C++: onnxruntime/core/providers/cuda/tensor/scatter_nd.cc#L138
[cpplint] reported by reviewdog 🐶 Add #include <vector> for vector<> [build/include_what_you_use] [4] Raw Output: onnxruntime/core/providers/cuda/tensor/scatter_nd.cc:138: Add #include <vector> for vector<> [build/include_what_you_use] [4]
Lint C++: onnxruntime/core/providers/cuda/tensor/scatter_nd.h#L51
[cpplint] reported by reviewdog 🐶 If an else has a brace on one side, it should have it on both [readability/braces] [5] Raw Output: onnxruntime/core/providers/cuda/tensor/scatter_nd.h:51: If an else has a brace on one side, it should have it on both [readability/braces] [5]
Lint C++: onnxruntime/core/providers/cuda/tensor/scatter_nd.h#L52
[cpplint] reported by reviewdog 🐶 Lines should be <= 120 characters long [whitespace/line_length] [2] Raw Output: onnxruntime/core/providers/cuda/tensor/scatter_nd.h:52: Lines should be <= 120 characters long [whitespace/line_length] [2]
Lint C++: onnxruntime/core/providers/cuda/tensor/scatter_nd.h#L54
[cpplint] reported by reviewdog 🐶 An else should appear on the same line as the preceding } [whitespace/newline] [4] Raw Output: onnxruntime/core/providers/cuda/tensor/scatter_nd.h:54: An else should appear on the same line as the preceding } [whitespace/newline] [4]
Lint C++: onnxruntime/core/providers/cuda/tensor/scatter_nd_impl.cu#L350
[cpplint] reported by reviewdog 🐶 Lines should be <= 120 characters long [whitespace/line_length] [2] Raw Output: onnxruntime/core/providers/cuda/tensor/scatter_nd_impl.cu:350: Lines should be <= 120 characters long [whitespace/line_length] [2]
Lint C++: onnxruntime/core/providers/rocm/rocm_execution_provider.cc#L2098
[cpplint] reported by reviewdog 🐶 Lines should be <= 120 characters long [whitespace/line_length] [2] Raw Output: onnxruntime/core/providers/rocm/rocm_execution_provider.cc:2098: Lines should be <= 120 characters long [whitespace/line_length] [2]