Skip to content

add GatherSliceToSplitFusion and Unittest #25676

add GatherSliceToSplitFusion and Unittest

add GatherSliceToSplitFusion and Unittest #25676

Triggered via pull request January 29, 2024 06:27
Status Failure
Total duration 23m 14s
Artifacts

lint.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 16 warnings
Python format
Process completed with exit code 1.
Lint C++
reviewdog: Too many results (annotations) in diff. You may miss some annotations due to GitHub limitation for annotation created by logging command. Please check GitHub Actions log console to see all results. Limitation: - 10 warning annotations and 10 error annotations per step - 50 annotations per job (sum of annotations from all the steps) - 50 annotations per run (separate from the job annotations, these annotations aren't created by users) Source: https://github.community/t5/GitHub-Actions/Maximum-number-of-annotations-that-can-be-created-using-GitHub/m-p/39085
Python format
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/toolchain@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Python format
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Python format
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Python format
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Python format
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Python format
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Lint C++: onnxruntime/core/optimizer/gather_slice_fusion.cc#L268
[cpplint] reported by reviewdog 🐶 Redundant blank line at the end of a code block should be deleted. [whitespace/blank_line] [3] Raw Output: onnxruntime/core/optimizer/gather_slice_fusion.cc:268: Redundant blank line at the end of a code block should be deleted. [whitespace/blank_line] [3]
Lint C++: onnxruntime/core/optimizer/gather_slice_fusion.cc#L299
[cpplint] reported by reviewdog 🐶 If an else has a brace on one side, it should have it on both [readability/braces] [5] Raw Output: onnxruntime/core/optimizer/gather_slice_fusion.cc:299: If an else has a brace on one side, it should have it on both [readability/braces] [5]
Lint C++: onnxruntime/core/optimizer/gather_slice_fusion.cc#L312
[cpplint] reported by reviewdog 🐶 Closing ) should be moved to the previous line [whitespace/parens] [2] Raw Output: onnxruntime/core/optimizer/gather_slice_fusion.cc:312: Closing ) should be moved to the previous line [whitespace/parens] [2]
Lint C++: onnxruntime/core/optimizer/gather_slice_fusion.cc#L353
[cpplint] reported by reviewdog 🐶 Namespace should be terminated with "// namespace onnxruntime" [readability/namespace] [5] Raw Output: onnxruntime/core/optimizer/gather_slice_fusion.cc:353: Namespace should be terminated with "// namespace onnxruntime" [readability/namespace] [5]
Lint C++: onnxruntime/core/optimizer/gather_slice_fusion.h#L17
[cpplint] reported by reviewdog 🐶 private: should be indented +1 space inside class GatherSliceToSplitFusion [whitespace/indent] [3] Raw Output: onnxruntime/core/optimizer/gather_slice_fusion.h:17: private: should be indented +1 space inside class GatherSliceToSplitFusion [whitespace/indent] [3]
Lint C++: onnxruntime/core/optimizer/gather_slice_fusion.h#L27
[cpplint] reported by reviewdog 🐶 public: should be indented +1 space inside class GatherSliceToSplitFusion [whitespace/indent] [3] Raw Output: onnxruntime/core/optimizer/gather_slice_fusion.h:27: public: should be indented +1 space inside class GatherSliceToSplitFusion [whitespace/indent] [3]
Lint C++: onnxruntime/core/optimizer/gather_slice_fusion.h#L28
[cpplint] reported by reviewdog 🐶 Constructors callable with one argument should be marked explicit. [runtime/explicit] [5] Raw Output: onnxruntime/core/optimizer/gather_slice_fusion.h:28: Constructors callable with one argument should be marked explicit. [runtime/explicit] [5]
Lint C++: onnxruntime/core/optimizer/gather_slice_fusion.h#L32
[cpplint] reported by reviewdog 🐶 Redundant blank line at the end of a code block should be deleted. [whitespace/blank_line] [3] Raw Output: onnxruntime/core/optimizer/gather_slice_fusion.h:32: Redundant blank line at the end of a code block should be deleted. [whitespace/blank_line] [3]
Lint C++: onnxruntime/core/optimizer/gather_slice_fusion.h#L34
[cpplint] reported by reviewdog 🐶 Namespace should be terminated with "// namespace onnxruntime" [readability/namespace] [5] Raw Output: onnxruntime/core/optimizer/gather_slice_fusion.h:34: Namespace should be terminated with "// namespace onnxruntime" [readability/namespace] [5]
Lint C++: onnxruntime/test/optimizer/graph_transform_test.cc#L7721
[cpplint] reported by reviewdog 🐶 You don't need a ; after a } [readability/braces] [4] Raw Output: onnxruntime/test/optimizer/graph_transform_test.cc:7721: You don't need a ; after a } [readability/braces] [4]