ORT ETW dynamic logging that improves ORT diagnosability & performance #24292
Triggered via pull request
December 20, 2023 20:05
Status
Failure
Total duration
22m 56s
Artifacts
–
lint.yml
on: pull_request
Optional Lint
28s
Python format
4m 57s
Lint C++
22m 47s
Lint JavaScript
26s
Annotations
1 error and 15 warnings
Lint C++
reviewdog: Too many results (annotations) in diff.
You may miss some annotations due to GitHub limitation for annotation created by logging command.
Please check GitHub Actions log console to see all results.
Limitation:
- 10 warning annotations and 10 error annotations per step
- 50 annotations per job (sum of annotations from all the steps)
- 50 annotations per run (separate from the job annotations, these annotations aren't created by users)
Source: https://github.community/t5/GitHub-Actions/Maximum-number-of-annotations-that-can-be-created-using-GitHub/m-p/39085
|
Python format
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Python format
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Python format
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Python format
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Python format
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Lint C++:
include/onnxruntime/core/common/logging/logging.h#L78
[cpplint] reported by reviewdog 🐶
Use int16/int64/etc, rather than the C type long [runtime/int] [4]
Raw Output:
include/onnxruntime/core/common/logging/logging.h:78: Use int16/int64/etc, rather than the C type long [runtime/int] [4]
|
Lint C++:
onnxruntime/core/platform/windows/logging/etw_sink.h#L23
[cpplint] reported by reviewdog 🐶
<mutex> is an unapproved C++11 header. [build/c++11] [5]
Raw Output:
onnxruntime/core/platform/windows/logging/etw_sink.h:23: <mutex> is an unapproved C++11 header. [build/c++11] [5]
|
Lint C++:
onnxruntime/core/platform/windows/logging/etw_sink.h#L51
[cpplint] reported by reviewdog 🐶
Lines should be <= 120 characters long [whitespace/line_length] [2]
Raw Output:
onnxruntime/core/platform/windows/logging/etw_sink.h:51: Lines should be <= 120 characters long [whitespace/line_length] [2]
|
Lint C++:
onnxruntime/core/platform/windows/logging/etw_sink.h#L83
[cpplint] reported by reviewdog 🐶
Lines should be <= 120 characters long [whitespace/line_length] [2]
Raw Output:
onnxruntime/core/platform/windows/logging/etw_sink.h:83: Lines should be <= 120 characters long [whitespace/line_length] [2]
|
Lint C++:
onnxruntime/core/platform/windows/logging/etw_sink.h#L94
[cpplint] reported by reviewdog 🐶
Add #include <vector> for vector<> [build/include_what_you_use] [4]
Raw Output:
onnxruntime/core/platform/windows/logging/etw_sink.h:94: Add #include <vector> for vector<> [build/include_what_you_use] [4]
|
Lint C++:
onnxruntime/core/platform/windows/telemetry.cc#L20
[cpplint] reported by reviewdog 🐶
Include the directory when naming header files [build/include_subdir] [4]
Raw Output:
onnxruntime/core/platform/windows/telemetry.cc:20: Include the directory when naming header files [build/include_subdir] [4]
|
Lint C++:
onnxruntime/core/platform/windows/telemetry.cc#L182
[cpplint] reported by reviewdog 🐶
Extra space before ) [whitespace/parens] [2]
Raw Output:
onnxruntime/core/platform/windows/telemetry.cc:182: Extra space before ) [whitespace/parens] [2]
|
Lint C++:
onnxruntime/core/providers/qnn/builder/qnn_backend_manager.cc#L856
[cpplint] reported by reviewdog 🐶
Use int16/int64/etc, rather than the C type long [runtime/int] [4]
Raw Output:
onnxruntime/core/providers/qnn/builder/qnn_backend_manager.cc:856: Use int16/int64/etc, rather than the C type long [runtime/int] [4]
|
Lint C++:
onnxruntime/core/providers/qnn/builder/qnn_backend_manager.cc#L878
[cpplint] reported by reviewdog 🐶
Lines should be <= 120 characters long [whitespace/line_length] [2]
Raw Output:
onnxruntime/core/providers/qnn/builder/qnn_backend_manager.cc:878: Lines should be <= 120 characters long [whitespace/line_length] [2]
|
Lint C++:
onnxruntime/core/providers/qnn/builder/qnn_backend_manager.cc#L880
[cpplint] reported by reviewdog 🐶
Lines should be <= 120 characters long [whitespace/line_length] [2]
Raw Output:
onnxruntime/core/providers/qnn/builder/qnn_backend_manager.cc:880: Lines should be <= 120 characters long [whitespace/line_length] [2]
|