Skip to content
Lint

FIX: Our cmake script didn't check googletest's hash (#18826) #24133

Sign in to view logs

FIX: Our cmake script didn't check googletest's hash (#18826)

FIX: Our cmake script didn't check googletest's hash (#18826) #24133

Triggered via push December 15, 2023 16:48
@snnnsnnn
pushed d795fc6
main
Status Success
Total duration 5m 21s
Artifacts –

lint.yml

on: push
Optional Lint
26s
Optional Lint
Python format
5m 11s
Python format
Lint C++
2m 30s
Lint C++
Lint JavaScript
26s
Lint JavaScript
Fit to window
Zoom out
Zoom in

Annotations

66 warnings
Python format
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Python format
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Python format
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Python format
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Python format
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
[cpplint] onnxruntime/core/providers/vitisai/vitisai_provider_factory.cc#L20: onnxruntime/core/providers/vitisai/vitisai_provider_factory.cc#L20
Single-parameter constructors should be marked explicit. [runtime/explicit] [5]
[cpplint] onnxruntime/core/providers/webnn/builders/impl/builder_utils.cc#L57: onnxruntime/core/providers/webnn/builders/impl/builder_utils.cc#L57
Add #include <vector> for vector<> [build/include_what_you_use] [4]
[cpplint] onnxruntime/core/providers/webnn/builders/impl/builder_utils.h#L24: onnxruntime/core/providers/webnn/builders/impl/builder_utils.h#L24
Add #include <vector> for vector<> [build/include_what_you_use] [4]
[cpplint] orttraining/orttraining/core/framework/torch/torch_proxy.cc#L106: orttraining/orttraining/core/framework/torch/torch_proxy.cc#L106
Lines should be <= 120 characters long [whitespace/line_length] [2]
[cpplint] orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/ctx_pool.cc#L4: orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/ctx_pool.cc#L4
Include the directory when naming header files [build/include_subdir] [4]
[cpplint] orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/ctx_pool.h#L61: orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/ctx_pool.h#L61
You don't need a ; after a } [readability/braces] [4]
[cpplint] orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/ctx_pool.h#L62: orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/ctx_pool.h#L62
You don't need a ; after a } [readability/braces] [4]
[cpplint] orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/ctx_pool.h#L44: orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/ctx_pool.h#L44
Add #include <utility> for move [build/include_what_you_use] [4]
[cpplint] orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/ctx_pool.h#L69: orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/ctx_pool.h#L69
Add #include <memory> for shared_ptr<> [build/include_what_you_use] [4]
[cpplint] orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/ctx_pool.h#L69: orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/ctx_pool.h#L69
Add #include <unordered_map> for unordered_map<> [build/include_what_you_use] [4]
[cpplint] orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_bw.cc#L4: orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_bw.cc#L4
Include the directory when naming header files [build/include_subdir] [4]
[cpplint] orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_bw.cc#L5: orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_bw.cc#L5
Include the directory when naming header files [build/include_subdir] [4]
[cpplint] orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_bw.cc#L6: orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_bw.cc#L6
Include the directory when naming header files [build/include_subdir] [4]
[cpplint] orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_bw.cc#L8: orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_bw.cc#L8
Found C system header after other header. Should be: custom_function_bw.h, c system, c++ system, other. [build/include_order] [4]
[cpplint] orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_bw.cc#L9: orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_bw.cc#L9
Found C system header after other header. Should be: custom_function_bw.h, c system, c++ system, other. [build/include_order] [4]
[cpplint] orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_bw.cc#L10: orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_bw.cc#L10
Found C system header after other header. Should be: custom_function_bw.h, c system, c++ system, other. [build/include_order] [4]
[cpplint] orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_bw.cc#L65: orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_bw.cc#L65
Add #include <string> for string [build/include_what_you_use] [4]
[cpplint] orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_bw.cc#L122: orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_bw.cc#L122
Add #include <unordered_map> for unordered_map<> [build/include_what_you_use] [4]
[cpplint] orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_bw.cc#L152: orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_bw.cc#L152
Add #include <vector> for vector<> [build/include_what_you_use] [4]
[cpplint] orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_bw.h#L16: orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_bw.h#L16
Add #include <vector> for vector<> [build/include_what_you_use] [4]
[cpplint] orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_fw.cc#L4: orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_fw.cc#L4
Include the directory when naming header files [build/include_subdir] [4]
[cpplint] orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_fw.cc#L5: orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_fw.cc#L5
Include the directory when naming header files [build/include_subdir] [4]
[cpplint] orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_fw.cc#L6: orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_fw.cc#L6
Include the directory when naming header files [build/include_subdir] [4]
[cpplint] orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_fw.cc#L7: orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_fw.cc#L7
Found C system header after other header. Should be: custom_function_fw.h, c system, c++ system, other. [build/include_order] [4]
[cpplint] orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_fw.cc#L8: orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_fw.cc#L8
Found C system header after other header. Should be: custom_function_fw.h, c system, c++ system, other. [build/include_order] [4]
[cpplint] orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_fw.cc#L9: orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_fw.cc#L9
Found C system header after other header. Should be: custom_function_fw.h, c system, c++ system, other. [build/include_order] [4]
[cpplint] orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_fw.cc#L10: orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_fw.cc#L10
Found C system header after other header. Should be: custom_function_fw.h, c system, c++ system, other. [build/include_order] [4]
[cpplint] orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_fw.cc#L11: orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_fw.cc#L11
Found C system header after other header. Should be: custom_function_fw.h, c system, c++ system, other. [build/include_order] [4]
[cpplint] orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_fw.cc#L12: orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_fw.cc#L12
Found C system header after other header. Should be: custom_function_fw.h, c system, c++ system, other. [build/include_order] [4]
[cpplint] orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_fw.cc#L13: orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_fw.cc#L13
Found C system header after other header. Should be: custom_function_fw.h, c system, c++ system, other. [build/include_order] [4]
[cpplint] orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_fw.cc#L14: orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_fw.cc#L14
Found C system header after other header. Should be: custom_function_fw.h, c system, c++ system, other. [build/include_order] [4]
[cpplint] orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_fw.cc#L66: orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_fw.cc#L66
Using C-style cast. Use reinterpret_cast<THPFunction*>(...) instead [readability/casting] [4]
[cpplint] orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_fw.cc#L162: orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_fw.cc#L162
Using C-style cast. Use reinterpret_cast<THPFunction*>(...) instead [readability/casting] [4]
[cpplint] orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_fw.cc#L218: orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_fw.cc#L218
Lines should be <= 120 characters long [whitespace/line_length] [2]
[cpplint] orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_fw.cc#L234: orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_fw.cc#L234
Lines should be <= 120 characters long [whitespace/line_length] [2]
[cpplint] orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_fw.cc#L236: orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_fw.cc#L236
Lines should be <= 120 characters long [whitespace/line_length] [2]
[cpplint] orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_fw.cc#L253: orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_fw.cc#L253
Lines should be <= 120 characters long [whitespace/line_length] [2]
[cpplint] orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_fw.cc#L157: orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_fw.cc#L157
Add #include <memory> for shared_ptr<> [build/include_what_you_use] [4]
[cpplint] orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_fw.cc#L453: orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_fw.cc#L453
Add #include <unordered_map> for unordered_map<> [build/include_what_you_use] [4]
[cpplint] orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_fw.cc#L481: orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_fw.cc#L481
Add #include <string> for string [build/include_what_you_use] [4]
[cpplint] orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_fw.cc#L484: orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_fw.cc#L484
Add #include <vector> for vector<> [build/include_what_you_use] [4]
[cpplint] orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_fw.h#L16: orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_fw.h#L16
Add #include <vector> for vector<> [build/include_what_you_use] [4]
[cpplint] orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_shared.cc#L4: orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_shared.cc#L4
Include the directory when naming header files [build/include_subdir] [4]
[cpplint] orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_shared.cc#L5: orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_shared.cc#L5
Include the directory when naming header files [build/include_subdir] [4]
[cpplint] orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_shared.cc#L6: orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_shared.cc#L6
Found C system header after other header. Should be: custom_function_shared.h, c system, c++ system, other. [build/include_order] [4]
[cpplint] orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_shared.cc#L7: orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_shared.cc#L7
Found C system header after other header. Should be: custom_function_shared.h, c system, c++ system, other. [build/include_order] [4]
[cpplint] orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_shared.cc#L74: orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_shared.cc#L74
Lines should be <= 120 characters long [whitespace/line_length] [2]
[cpplint] orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_shared.cc#L190: orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_shared.cc#L190
Lines should be <= 120 characters long [whitespace/line_length] [2]
[cpplint] orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_shared.cc#L211: orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_shared.cc#L211
Using C-style cast. Use reinterpret_cast<DLManagedTensor*>(...) instead [readability/casting] [4]
[cpplint] orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_shared.cc#L137: orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_shared.cc#L137
Add #include <unordered_map> for unordered_map<> [build/include_what_you_use] [4]
[cpplint] orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_shared.cc#L139: orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_shared.cc#L139
Add #include <string> for string [build/include_what_you_use] [4]
[cpplint] orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_shared.cc#L169: orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_shared.cc#L169
Add #include <vector> for vector<> [build/include_what_you_use] [4]
[cpplint] orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_shared.h#L37: orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_shared.h#L37
Add #include <tuple> for tuple<> [build/include_what_you_use] [4]
[cpplint] orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_shared.h#L72: orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_shared.h#L72
Add #include <vector> for vector<> [build/include_what_you_use] [4]
[cpplint] orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_shared.h#L88: orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_shared.h#L88
Add #include <string> for string [build/include_what_you_use] [4]
[cpplint] orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_shared.h#L88: orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/custom_function_shared.h#L88
Add #include <unordered_map> for unordered_map<> [build/include_what_you_use] [4]
[cpplint] orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/torch_interop_utils.cc#L4: orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/torch_interop_utils.cc#L4
Include the directory when naming header files [build/include_subdir] [4]
[cpplint] orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/torch_interop_utils.cc#L5: orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/torch_interop_utils.cc#L5
Include the directory when naming header files [build/include_subdir] [4]
[cpplint] orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/torch_interop_utils.cc#L6: orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/torch_interop_utils.cc#L6
Include the directory when naming header files [build/include_subdir] [4]
[cpplint] orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/torch_interop_utils.cc#L13: orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/torch_interop_utils.cc#L13
Lines should be <= 120 characters long [whitespace/line_length] [2]
[cpplint] orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/torch_interop_utils.cc#L14: orttraining/orttraining/python/training/ortmodule/torch_cpp_extensions/cpu/torch_interop_utils/torch_interop_utils.cc#L14
Lines should be <= 120 characters long [whitespace/line_length] [2]