Integrate high-performance x64 gemm library to MLAS #24074
lint.yml
on: pull_request
Optional Lint
28s
Python format
5m 19s
Lint C++
22m 42s
Lint JavaScript
23s
Annotations
1 error and 16 warnings
Lint C++
reviewdog: Too many results (annotations) in diff.
You may miss some annotations due to GitHub limitation for annotation created by logging command.
Please check GitHub Actions log console to see all results.
Limitation:
- 10 warning annotations and 10 error annotations per step
- 50 annotations per job (sum of annotations from all the steps)
- 50 annotations per run (separate from the job annotations, these annotations aren't created by users)
Source: https://github.community/t5/GitHub-Actions/Maximum-number-of-annotations-that-can-be-created-using-GitHub/m-p/39085
|
Optional Lint:
onnxruntime/core/mlas/lib/x86_64/jblas/jblas/xbyak/xbyak.h#L159
[misspell] reported by reviewdog 🐶
"expresison" is a misspelling of "expressions"
Raw Output:
./onnxruntime/core/mlas/lib/x86_64/jblas/jblas/xbyak/xbyak.h:159:44: "expresison" is a misspelling of "expressions"
|
Python format
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Python format
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Python format
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Python format
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Python format
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Lint C++:
onnxruntime/core/mlas/lib/jblas_defs.h#L43
[cpplint] reported by reviewdog 🐶
public: should be indented +1 space inside class ORTThreading [whitespace/indent] [3]
Raw Output:
onnxruntime/core/mlas/lib/jblas_defs.h:43: public: should be indented +1 space inside class ORTThreading [whitespace/indent] [3]
|
Lint C++:
onnxruntime/core/mlas/lib/jblas_defs.h#L44
[cpplint] reported by reviewdog 🐶
Single-parameter constructors should be marked explicit. [runtime/explicit] [5]
Raw Output:
onnxruntime/core/mlas/lib/jblas_defs.h:44: Single-parameter constructors should be marked explicit. [runtime/explicit] [5]
|
Lint C++:
onnxruntime/core/mlas/lib/jblas_defs.h#L46
[cpplint] reported by reviewdog 🐶
"virtual" is redundant since function is already declared as "override" [readability/inheritance] [4]
Raw Output:
onnxruntime/core/mlas/lib/jblas_defs.h:46: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4]
|
Lint C++:
onnxruntime/core/mlas/lib/jblas_defs.h#L47
[cpplint] reported by reviewdog 🐶
"virtual" is redundant since function is already declared as "override" [readability/inheritance] [4]
Raw Output:
onnxruntime/core/mlas/lib/jblas_defs.h:47: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4]
|
Lint C++:
onnxruntime/core/mlas/lib/jblas_gemm.cpp#L16
[cpplint] reported by reviewdog 🐶
Include the directory when naming header files [build/include_subdir] [4]
Raw Output:
onnxruntime/core/mlas/lib/jblas_gemm.cpp:16: Include the directory when naming header files [build/include_subdir] [4]
|
Lint C++:
onnxruntime/core/mlas/lib/jblas_gemm.cpp#L18
[cpplint] reported by reviewdog 🐶
Include the directory when naming header files [build/include_subdir] [4]
Raw Output:
onnxruntime/core/mlas/lib/jblas_gemm.cpp:18: Include the directory when naming header files [build/include_subdir] [4]
|
Lint C++:
onnxruntime/core/mlas/lib/jblas_gemm.cpp#L19
[cpplint] reported by reviewdog 🐶
Include the directory when naming header files [build/include_subdir] [4]
Raw Output:
onnxruntime/core/mlas/lib/jblas_gemm.cpp:19: Include the directory when naming header files [build/include_subdir] [4]
|
Lint C++:
onnxruntime/core/mlas/lib/jblas_gemm.cpp#L21
[cpplint] reported by reviewdog 🐶
Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]
Raw Output:
onnxruntime/core/mlas/lib/jblas_gemm.cpp:21: Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]
|
Lint C++:
onnxruntime/core/mlas/lib/jblas_gemm.cpp#L25
[cpplint] reported by reviewdog 🐶
{ should almost always be at the end of the previous line [whitespace/braces] [4]
Raw Output:
onnxruntime/core/mlas/lib/jblas_gemm.cpp:25: { should almost always be at the end of the previous line [whitespace/braces] [4]
|
Lint C++:
onnxruntime/core/mlas/lib/jblas_gemm.cpp#L30
[cpplint] reported by reviewdog 🐶
{ should almost always be at the end of the previous line [whitespace/braces] [4]
Raw Output:
onnxruntime/core/mlas/lib/jblas_gemm.cpp:30: { should almost always be at the end of the previous line [whitespace/braces] [4]
|