Skip to content

CR feedback

CR feedback #25167

Triggered via push November 20, 2023 18:16
Status Success
Total duration 25s
Artifacts
Validation
16s
Validation
Fit to window
Zoom out
Zoom in

Annotations

5 warnings
[cpplint] winml/lib/Api/HardwareCoreEnumerator.cpp#L1: winml/lib/Api/HardwareCoreEnumerator.cpp#L1
At least two spaces is best between code and comments [whitespace/comments] [2]
[cpplint] winml/lib/Api/HardwareCoreEnumerator.cpp#L30: winml/lib/Api/HardwareCoreEnumerator.cpp#L30
Closing ) should be moved to the previous line [whitespace/parens] [2]
[cpplint] winml/lib/Api/HardwareCoreEnumerator.cpp#L26: winml/lib/Api/HardwareCoreEnumerator.cpp#L26
Add #include <memory> for make_unique<> [build/include_what_you_use] [4]
[cpplint] winml/lib/Api/HardwareCoreEnumerator.cpp#L34: winml/lib/Api/HardwareCoreEnumerator.cpp#L34
Add #include <utility> for move [build/include_what_you_use] [4]
[cpplint] winml/lib/Api/HardwareCoreEnumerator.h#L1: winml/lib/Api/HardwareCoreEnumerator.h#L1
At least two spaces is best between code and comments [whitespace/comments] [2]