Skip to content

Merge branch 'main' into chi/trt_engine_wrapper #25093

Merge branch 'main' into chi/trt_engine_wrapper

Merge branch 'main' into chi/trt_engine_wrapper #25093

Triggered via push November 19, 2023 20:03
Status Success
Total duration 22s
Artifacts
Validation
13s
Validation
Fit to window
Zoom out
Zoom in

Annotations

138 warnings
[cpplint] onnxruntime/core/providers/tensorrt/onnx_ctx_model_helper.cc#L8: onnxruntime/core/providers/tensorrt/onnx_ctx_model_helper.cc#L8
Include the directory when naming header files [build/include_subdir] [4]
[cpplint] onnxruntime/core/providers/tensorrt/onnx_ctx_model_helper.cc#L81: onnxruntime/core/providers/tensorrt/onnx_ctx_model_helper.cc#L81
Using C-style cast. Use reinterpret_cast<char*>(...) instead [readability/casting] [4]
[cpplint] onnxruntime/core/providers/tensorrt/onnx_ctx_model_helper.h#L14: onnxruntime/core/providers/tensorrt/onnx_ctx_model_helper.h#L14
For a static/global string constant, use a C style string instead: "static const char EPCONTEXT_OP[]". [runtime/string] [4]
[cpplint] onnxruntime/core/providers/tensorrt/onnx_ctx_model_helper.h#L15: onnxruntime/core/providers/tensorrt/onnx_ctx_model_helper.h#L15
For a static/global string constant, use a C style string instead: "static const char MAIN_CONTEXT[]". [runtime/string] [4]
[cpplint] onnxruntime/core/providers/tensorrt/onnx_ctx_model_helper.h#L16: onnxruntime/core/providers/tensorrt/onnx_ctx_model_helper.h#L16
For a static/global string constant, use a C style string instead: "static const char EMBED_MODE[]". [runtime/string] [4]
[cpplint] onnxruntime/core/providers/tensorrt/onnx_ctx_model_helper.h#L17: onnxruntime/core/providers/tensorrt/onnx_ctx_model_helper.h#L17
For a static/global string constant, use a C style string instead: "static const char EP_CACHE_CONTEXT[]". [runtime/string] [4]
[cpplint] onnxruntime/core/providers/tensorrt/onnx_ctx_model_helper.h#L18: onnxruntime/core/providers/tensorrt/onnx_ctx_model_helper.h#L18
For a static/global string constant, use a C style string instead: "static const char EP_SDK_VER[]". [runtime/string] [4]
[cpplint] onnxruntime/core/providers/tensorrt/onnx_ctx_model_helper.h#L19: onnxruntime/core/providers/tensorrt/onnx_ctx_model_helper.h#L19
For a static/global string constant, use a C style string instead: "static const char COMPUTE_CAPABILITY[]". [runtime/string] [4]
[cpplint] onnxruntime/core/providers/tensorrt/onnx_ctx_model_helper.h#L20: onnxruntime/core/providers/tensorrt/onnx_ctx_model_helper.h#L20
For a static/global string constant, use a C style string instead: "static const char PARTITION_NAME[]". [runtime/string] [4]
[cpplint] onnxruntime/core/providers/tensorrt/onnx_ctx_model_helper.h#L21: onnxruntime/core/providers/tensorrt/onnx_ctx_model_helper.h#L21
For a static/global string constant, use a C style string instead: "static const char SOURCE[]". [runtime/string] [4]
[cpplint] onnxruntime/core/providers/tensorrt/tensorrt_execution_provider.cc#L2478: onnxruntime/core/providers/tensorrt/tensorrt_execution_provider.cc#L2478
Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
[cpplint] onnxruntime/core/providers/tensorrt/tensorrt_execution_provider.cc#L2863: onnxruntime/core/providers/tensorrt/tensorrt_execution_provider.cc#L2863
If an else has a brace on one side, it should have it on both [readability/braces] [5]
[cpplint] onnxruntime/core/providers/tensorrt/tensorrt_execution_provider.cc#L3012: onnxruntime/core/providers/tensorrt/tensorrt_execution_provider.cc#L3012
Using C-style cast. Use reinterpret_cast<char*>(...) instead [readability/casting] [4]
[cpplint] onnxruntime/core/providers/tensorrt/tensorrt_execution_provider.cc#L3174: onnxruntime/core/providers/tensorrt/tensorrt_execution_provider.cc#L3174
Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
[cpplint] onnxruntime/core/providers/tensorrt/tensorrt_execution_provider.cc#L3270: onnxruntime/core/providers/tensorrt/tensorrt_execution_provider.cc#L3270
Using C-style cast. Use reinterpret_cast<char*>(...) instead [readability/casting] [4]
[cpplint] onnxruntime/core/providers/tensorrt/tensorrt_execution_provider.cc#L3660: onnxruntime/core/providers/tensorrt/tensorrt_execution_provider.cc#L3660
Small and focused functions are preferred: TensorrtExecutionProvider::CreateNodeComputeFromGraph() has 741 non-comment lines (error triggered by exceeding 500 lines). [readability/fn_size] [1]
[cpplint] onnxruntime/core/session/custom_ops.cc#L314: onnxruntime/core/session/custom_ops.cc#L314
Lines should be <= 120 characters long [whitespace/line_length] [2]
[cpplint] onnxruntime/core/session/custom_ops.cc#L317: onnxruntime/core/session/custom_ops.cc#L317
Lines should be <= 120 characters long [whitespace/line_length] [2]
[cpplint] onnxruntime/core/session/ort_apis.h#L187: onnxruntime/core/session/ort_apis.h#L187
Lines should be <= 120 characters long [whitespace/line_length] [2]
[cpplint] onnxruntime/test/providers/cpu/nn/dropout_op_test.cc#L33: onnxruntime/test/providers/cpu/nn/dropout_op_test.cc#L33
Lines should be <= 120 characters long [whitespace/line_length] [2]