Block-wise 4b quantization matmul operator change #21694
lint.yml
on: pull_request
Optional Lint
35s
Python format
4m 34s
Lint C++
27m 50s
Lint JavaScript
30s
Annotations
1 error and 15 warnings
Lint C++
reviewdog: Too many results (annotations) in diff.
You may miss some annotations due to GitHub limitation for annotation created by logging command.
Please check GitHub Actions log console to see all results.
Limitation:
- 10 warning annotations and 10 error annotations per step
- 50 annotations per job (sum of annotations from all the steps)
- 50 annotations per run (separate from the job annotations, these annotations aren't created by users)
Source: https://github.community/t5/GitHub-Actions/Maximum-number-of-annotations-that-can-be-created-using-GitHub/m-p/39085
|
Python format
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Python format
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Python format
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Python format
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Python format
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Lint C++:
onnxruntime/contrib_ops/cpu/quantization/matmul_nbits.cc#L20
[cpplint] reported by reviewdog 🐶
Lines should be <= 120 characters long [whitespace/line_length] [2]
Raw Output:
onnxruntime/contrib_ops/cpu/quantization/matmul_nbits.cc:20: Lines should be <= 120 characters long [whitespace/line_length] [2]
|
Lint C++:
onnxruntime/contrib_ops/cuda/quantization/matmul_nbits.cc#L30
[cpplint] reported by reviewdog 🐶
Lines should be <= 120 characters long [whitespace/line_length] [2]
Raw Output:
onnxruntime/contrib_ops/cuda/quantization/matmul_nbits.cc:30: Lines should be <= 120 characters long [whitespace/line_length] [2]
|
Lint C++:
onnxruntime/contrib_ops/cuda/quantization/matmul_nbits.cu#L127
[cpplint] reported by reviewdog 🐶
At least two spaces is best between code and comments [whitespace/comments] [2]
Raw Output:
onnxruntime/contrib_ops/cuda/quantization/matmul_nbits.cu:127: At least two spaces is best between code and comments [whitespace/comments] [2]
|
Lint C++:
onnxruntime/contrib_ops/cuda/quantization/matmul_nbits.cu#L128
[cpplint] reported by reviewdog 🐶
At least two spaces is best between code and comments [whitespace/comments] [2]
Raw Output:
onnxruntime/contrib_ops/cuda/quantization/matmul_nbits.cu:128: At least two spaces is best between code and comments [whitespace/comments] [2]
|
Lint C++:
onnxruntime/contrib_ops/cuda/quantization/matmul_nbits.cu#L138
[cpplint] reported by reviewdog 🐶
At least two spaces is best between code and comments [whitespace/comments] [2]
Raw Output:
onnxruntime/contrib_ops/cuda/quantization/matmul_nbits.cu:138: At least two spaces is best between code and comments [whitespace/comments] [2]
|
Lint C++:
onnxruntime/contrib_ops/cuda/quantization/matmul_nbits.cu#L139
[cpplint] reported by reviewdog 🐶
At least two spaces is best between code and comments [whitespace/comments] [2]
Raw Output:
onnxruntime/contrib_ops/cuda/quantization/matmul_nbits.cu:139: At least two spaces is best between code and comments [whitespace/comments] [2]
|
Lint C++:
onnxruntime/core/mlas/lib/q4_dq.cpp#L876
[cpplint] reported by reviewdog 🐶
Closing ) should be moved to the previous line [whitespace/parens] [2]
Raw Output:
onnxruntime/core/mlas/lib/q4_dq.cpp:876: Closing ) should be moved to the previous line [whitespace/parens] [2]
|
Lint C++:
onnxruntime/test/contrib_ops/matmul_4bits_test.cc#L77
[cpplint] reported by reviewdog 🐶
Using C-style cast. Use static_cast<int>(...) instead [readability/casting] [4]
Raw Output:
onnxruntime/test/contrib_ops/matmul_4bits_test.cc:77: Using C-style cast. Use static_cast<int>(...) instead [readability/casting] [4]
|
Lint C++:
onnxruntime/test/contrib_ops/matmul_4bits_test.cc#L81
[cpplint] reported by reviewdog 🐶
Using C-style cast. Use static_cast<int>(...) instead [readability/casting] [4]
Raw Output:
onnxruntime/test/contrib_ops/matmul_4bits_test.cc:81: Using C-style cast. Use static_cast<int>(...) instead [readability/casting] [4]
|
Lint C++:
onnxruntime/test/contrib_ops/matmul_4bits_test.cc#L86
[cpplint] reported by reviewdog 🐶
Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
Raw Output:
onnxruntime/test/contrib_ops/matmul_4bits_test.cc:86: Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
|