Adding CUDNN Frontend and use for CUDA NN Convolution #31933
Annotations
1 error and 10 warnings
reviewdog: Too many results (annotations) in diff.
You may miss some annotations due to GitHub limitation for annotation created by logging command.
Please check GitHub Actions log console to see all results.
Limitation:
- 10 warning annotations and 10 error annotations per step
- 50 annotations per job (sum of annotations from all the steps)
- 50 annotations per run (separate from the job annotations, these annotations aren't created by users)
Source: https://github.com/orgs/community/discussions/26680#discussioncomment-3252835
|
include/onnxruntime/core/providers/cuda/cuda_provider_options.h#L41
[cpplint] reported by reviewdog 🐶
Lines should be <= 120 characters long [whitespace/line_length] [2]
Raw Output:
include/onnxruntime/core/providers/cuda/cuda_provider_options.h:41: Lines should be <= 120 characters long [whitespace/line_length] [2]
|
onnxruntime/contrib_ops/cuda/fused_conv.cc#L42
[cpplint] reported by reviewdog 🐶
Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
Raw Output:
onnxruntime/contrib_ops/cuda/fused_conv.cc:42: Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
|
onnxruntime/contrib_ops/cuda/fused_conv.cc#L63
[cpplint] reported by reviewdog 🐶
Single-parameter constructors should be marked explicit. [runtime/explicit] [5]
Raw Output:
onnxruntime/contrib_ops/cuda/fused_conv.cc:63: Single-parameter constructors should be marked explicit. [runtime/explicit] [5]
|
onnxruntime/contrib_ops/cuda/fused_conv.cc#L197
[cpplint] reported by reviewdog 🐶
Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
Raw Output:
onnxruntime/contrib_ops/cuda/fused_conv.cc:197: Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
|
onnxruntime/contrib_ops/cuda/fused_conv.cc#L458
[cpplint] reported by reviewdog 🐶
Could not find a newline character at the end of the file. [whitespace/ending_newline] [5]
Raw Output:
onnxruntime/contrib_ops/cuda/fused_conv.cc:458: Could not find a newline character at the end of the file. [whitespace/ending_newline] [5]
|
onnxruntime/core/providers/cuda/cudnn_fe_call.cc#L6
[cpplint] reported by reviewdog 🐶
Found C system header after other header. Should be: cudnn_fe_call.h, c system, c++ system, other. [build/include_order] [4]
Raw Output:
onnxruntime/core/providers/cuda/cudnn_fe_call.cc:6: Found C system header after other header. Should be: cudnn_fe_call.h, c system, c++ system, other. [build/include_order] [4]
|
onnxruntime/core/providers/cuda/cudnn_fe_call.cc#L18
[cpplint] reported by reviewdog 🐶
Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]
Raw Output:
onnxruntime/core/providers/cuda/cudnn_fe_call.cc:18: Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]
|
onnxruntime/core/providers/cuda/cudnn_fe_call.cc#L79
[cpplint] reported by reviewdog 🐶
Almost always, snprintf is better than strcpy [runtime/printf] [4]
Raw Output:
onnxruntime/core/providers/cuda/cudnn_fe_call.cc:79: Almost always, snprintf is better than strcpy [runtime/printf] [4]
|
onnxruntime/core/providers/cuda/cudnn_fe_call.cc#L85
[cpplint] reported by reviewdog 🐶
If you can, use sizeof(str) instead of 1024 as the 2nd arg to snprintf. [runtime/printf] [3]
Raw Output:
onnxruntime/core/providers/cuda/cudnn_fe_call.cc:85: If you can, use sizeof(str) instead of 1024 as the 2nd arg to snprintf. [runtime/printf] [3]
|
onnxruntime/core/providers/cuda/nn/conv.cc#L235
[cpplint] reported by reviewdog 🐶
Line contains only semicolon. If this should be an empty statement, use {} instead. [whitespace/semicolon] [5]
Raw Output:
onnxruntime/core/providers/cuda/nn/conv.cc:235: Line contains only semicolon. If this should be an empty statement, use {} instead. [whitespace/semicolon] [5]
|
This job failed
Loading