Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running C tests after build #93

Merged
merged 80 commits into from
Mar 4, 2024
Merged

Running C tests after build #93

merged 80 commits into from
Mar 4, 2024

Conversation

jchen351
Copy link
Contributor

This pull request includes changes to the GitHub Actions workflows and the test/CMakeLists.txt file. The changes are aimed at improving the build and test process for different platforms and configurations. The changes include updating the actions/checkout action to version 4 and enabling submodules, removing the redundant git submodule update steps, restructuring the Docker-based build and test steps, adding test execution steps, and reorganizing the unit_tests executable in the test/CMakeLists.txt file.

Changes to GitHub Actions workflows:

  • .github/workflows/linux-cpu-arm64-build.yml, .github/workflows/linux-cpu-x64-build.yml, .github/workflows/linux-gpu-x64-build.yml, .github/workflows/win-cpu-arm64-build.yml, .github/workflows/win-cpu-x64-build.yml, .github/workflows/win-gpu-x64-build.yml: Updated actions/checkout to version 4 and enabled submodules. Removed the redundant git submodule update steps. [1] [2] [3] [4] [5] [6]

  • .github/workflows/linux-cpu-arm64-build.yml, .github/workflows/linux-gpu-x64-build.yml: Restructured the Docker-based build and test steps to separate the configuration, build, and test execution steps. [1] [2]

  • .github/workflows/linux-cpu-x64-build.yml, .github/workflows/win-cpu-arm64-build.yml, .github/workflows/win-cpu-x64-build.yml, .github/workflows/win-gpu-x64-build.yml: Added steps to execute unit tests. [1] [2] [3] [4]

Changes to test/CMakeLists.txt:

  • test/CMakeLists.txt: Reorganized the unit_tests executable to include c_api_tests.cpp, model_tests.cpp, sampling_tests.cpp, and sampling_benchmark.cpp.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@jchen351 jchen351 requested a review from snnn March 1, 2024 23:43
@jchen351 jchen351 requested a review from snnn March 2, 2024 01:07
@jchen351 jchen351 merged commit bf06b91 into main Mar 4, 2024
12 checks passed
@jchen351 jchen351 deleted the Cjian/cgt branch March 4, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants