Use dlopen in favor of direct dependency of ORT on Linux #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baijumeswani
approved these changes
Jul 25, 2024
skyline75489
force-pushed
the
jialli/dlopen
branch
from
331acde to
8bbe59a
Compare
skyline75489
force-pushed
the
jialli/dlopen
branch
from
8bbe59a to
5bada46
Compare
skyline75489
commented
Jul 26, 2024
skyline75489
changed the title
snnn
reviewed
Jul 26, 2024
snnn
approved these changes
Jul 26, 2024
|
Let's merge this to unblock other PRs. And then revisit the search strategy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement #693 on Linux.
Fixed CI breakage caused by microsoft/onnxruntime#21339, which modifies the SONAME to
libonnxruntime.so.1. But the ORT lib bundled in ORT 1.19(nightly) is namedlibonnxruntime.so.1.19.0.Related: microsoft/onnxruntime#21281