Enable shared libraries. #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How are the python bindings built with this, they should be statically linked as they don't use the C API. |
# Conflicts: # CMakeLists.txt
# target_link_libraries(python PRIVATE tokenizer)
# Conflicts: # CMakeLists.txt
RyanUnderhill
approved these changes
Feb 3, 2024
CMakeLists.txt
Outdated
| @@ -116,7 +116,7 @@ if(USE_TOKENIZER) | |||
| FetchContent_Declare(simdjson URL https://github.com/simdjson/simdjson/archive/refs/tags/v3.6.3.zip URL_HASH SHA1=2b063a2e81f74a5d1cb937fadf3d2fca0f1edb09) | |||
| FetchContent_MakeAvailable (simdjson) | |||
|
|
|||
| add_library (tokenizer ${tokenizer_srcs}) | |||
| add_library (tokenizer SHARED ${tokenizer_srcs}) | |||
There was a problem hiding this comment.
The tokenizer library should be part of the onnxruntime-genai library, not a separate shared library.
CMakeLists.txt
Outdated
| @@ -161,7 +161,7 @@ target_link_directories(python PRIVATE ${CMAKE_SOURCE_DIR}/ort/lib) | |||
| target_link_libraries(python PRIVATE onnxruntime-genai ${ONNXRUNTIME_LIB}) | |||
| set_target_properties(python PROPERTIES OUTPUT_NAME "onnxruntime_genai") | |||
| if (WIN32) | |||
| SET(WINDOWS_EXPORT_ALL_SYMBOLS ON) | |||
| SET(CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS ON) | |||
There was a problem hiding this comment.
Shouldn't we use a def file? We don't want to export all of the symbols, just the C API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.