Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore software adapters from DML device enumeration and use DXGI enumeration instead of dxcore #377

Merged

Conversation

PatriceVignola
Copy link
Contributor

There are 2 changes in this PR:

  1. Ignore software adapters like WARP and remote desktop from the enumeration. There's a weird behavior with these adapters where they will show up first no matter what, even if the HighPerformance enumeration is requested. This can cause very slow execution when using remote desktop, or simply if a device decides to enumerate the WARP software emulation device first.
  2. Use DXGI instead of DXCORE. DXGI works everywhere that dxcore works (except for Linux), but DXGI is supported on a wider range of Windows machines going back to the early days of Windows 10. This should allow the enumeration to work on far more devices.

@yufenglee
Copy link
Member

Does it fix this issue: #336

@baijumeswani baijumeswani merged commit d7d82a3 into main May 1, 2024
12 checks passed
@baijumeswani baijumeswani deleted the user/pavignol/ignore-software-adapters-from-enumeration branch May 1, 2024 23:46
baijumeswani pushed a commit that referenced this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants