Remove GenerateNextToken* special case functions #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ptions methods should be used instead.
|
Could you please check all the examples and benchmark tool? |
Yep, this previous change removed all references to the functions: #217 So this change doesn't affect any of the existing python scripts. |
yufenglee
approved these changes
Mar 23, 2024
jchen351
pushed a commit
that referenced
this pull request
Mar 23, 2024
set_search_options already supports the functionality, so the extra functions are confusing users since there are multiple ways to do the same thing. set_search_options is also more flexible as it supports all future options without the need for extra APIs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set_search_options already supports the functionality, so the extra functions are confusing users since there are multiple ways to do the same thing.
set_search_options is also more flexible as it supports all future options without the need for extra APIs.