Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address a DML regression caused by the continuous decoding changes #1159

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Address a DML regression caused by the continuous decoding changes #1159

wants to merge 3 commits into from

Conversation

baijumeswani
Copy link
Collaborator

@baijumeswani baijumeswani commented Dec 19, 2024 •
edited
Loading

Issues that this PR resolves:

  • For DML EP, the input ids must be allocated on CPU for the prompt case.
  • logits must use the static buffer only after the first Update for DML.
  • DML memory device type was unhandled due to changes in ORT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aciddelgado aciddelgado Awaiting requested review from aciddelgado

@RyanUnderhill RyanUnderhill Awaiting requested review from RyanUnderhill

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@baijumeswani