Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add new publish pipeline #727

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

rzhao271
Copy link
Contributor

@rzhao271 rzhao271 commented Nov 7, 2024

Also fixes up the existing pipeline to become a CI-only pipeline.
One issue with the new pipeline is that it uses the package.json version. I'm not sure how to let it auto-generate a new beta version.

@rzhao271 rzhao271 added this to the November 2024 milestone Nov 7, 2024
@rzhao271 rzhao271 requested a review from Tyriar November 7, 2024 18:36
@rzhao271 rzhao271 self-assigned this Nov 7, 2024
@Tyriar
Copy link
Member

Tyriar commented Nov 7, 2024

One issue with the new pipeline is that it uses the package.json version. I'm not sure how to let it auto-generate a new beta version.

It would be a shame to lose that, would it instead publish whenever the package.json changes in main?

@rzhao271
Copy link
Contributor Author

rzhao271 commented Nov 7, 2024

Afaik, the maintainer must manually set the package.json version, run a pipeline build, and get it approved, ref https://dev.azure.com/monacotools/Monaco/_build/results?buildId=297071&view=results

Edit: Adding Lad to the PR to confirm.

@rzhao271
Copy link
Contributor Author

rzhao271 commented Nov 12, 2024

I have changed the publish script to only increment the package.json version, and the YAML should now run that script to set the correct version before publishing the package. There is no verification build because the pipeline needs to be on the main branch for me to create a new pipeline in ADO for it.

@lszomoru
Copy link
Member

You should look at vsce as it implements the desired pattern to automatically update the package version based on the nextVersion pipeline input parameter - https://github.com/microsoft/vscode-vsce/blob/f1fc6d255d634849db9a7f28e59a031c49cd4918/build/azure-pipelines.yml#L18

@rzhao271
Copy link
Contributor Author

@lszomoru I believe the version format is different for node-pty: https://www.npmjs.com/package/node-pty?activeTab=versions

Here's what I see for @vscode/vsce: https://www.npmjs.com/package/@vscode/vsce?activeTab=versions

@lszomoru
Copy link
Member

If node-pty is using custom version number format then it is up to the package owner to increment it. If you specify the nextVersion template parameter (list vsce does) we will run npm version ${{ parameters.nextVersion }} --no-git-tag-version --allow-same-version to update the package.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants