-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add new publish pipeline #727
base: main
Are you sure you want to change the base?
Conversation
It would be a shame to lose that, would it instead publish whenever the package.json changes in main? |
Afaik, the maintainer must manually set the package.json version, run a pipeline build, and get it approved, ref https://dev.azure.com/monacotools/Monaco/_build/results?buildId=297071&view=results Edit: Adding Lad to the PR to confirm. |
ba3b771
to
2b77d25
Compare
I have changed the publish script to only increment the package.json version, and the YAML should now run that script to set the correct version before publishing the package. There is no verification build because the pipeline needs to be on the main branch for me to create a new pipeline in ADO for it. |
You should look at |
@lszomoru I believe the version format is different for node-pty: https://www.npmjs.com/package/node-pty?activeTab=versions Here's what I see for |
If node-pty is using custom version number format then it is up to the package owner to increment it. If you specify the |
Also fixes up the existing pipeline to become a CI-only pipeline.
One issue with the new pipeline is that it uses the package.json version. I'm not sure how to let it auto-generate a new beta version.