Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TPM Replay FW CFG Input Channel library instance #761

Merged

Conversation

makubacki
Copy link
Member

@makubacki makubacki commented Nov 6, 2023

Description

Adds a new library instance for QEMU platforms that allows a TPM
Replay event log to optionally be passed from the QEMU command
line.

See https://github.com/microsoft/mu_plus/tree/HEAD/TpmTestingPkg/TpmReplayPei#input-channel-fw_cfg
for more information about passing a TPM Replay log through the
FW CFG interface.

For reference, this readme has additional TPM Replay information:

https://github.com/microsoft/mu_tiano_platforms/blob/main/Platforms/Docs/Q35/Features/feature_tpm_replay.md

  • Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • Impacts security?
    • Security - Does the change have a direct security impact on an application,
      flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter
      validation improvement, ...
  • Breaking change?
    • Breaking change - Will anyone consuming this change experience a break
      in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call
      a function in a new library class in a pre-existing module, ...
  • Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • Includes documentation?
    • Documentation - Does the change contain explicit documentation additions
      outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation
      on an a separate Web page, ...

How This Was Tested

  • Passed FW CFG TPM event log through QemuQ35Pkg
  • Verified library integrated without a log being passed uses
    lower priority input channels as expected

Integration Instructions

N/A - The new input channel library instance for TPM Replay is integrated
in this change.

@makubacki makubacki added the type:feature-request A new feature proposal label Nov 6, 2023
@makubacki makubacki self-assigned this Nov 6, 2023
@makubacki makubacki force-pushed the add_tpm_replay_fwcfg_input_channel_lib branch from 267f857 to 19be3ca Compare November 6, 2023 15:45
@makubacki
Copy link
Member Author

Waiting on microsoft/mu_plus#352 to complete and then I'll update the Common/MU submodule a final time before completing this PR.

Adds a new library instance for QEMU platforms that allows a TPM
Replay event log to optionally be passed from the QEMU command
line.

See https://github.com/microsoft/mu_tiano_platforms/blob/main/Platforms/Docs/Q35/Features/feature_tpm_replay.md
for more information about passing a TPM Replay log through the
FW CFG interface.

Signed-off-by: Michael Kubacki <[email protected]>
@makubacki makubacki force-pushed the add_tpm_replay_fwcfg_input_channel_lib branch from 19be3ca to d419e90 Compare November 6, 2023 21:13
@makubacki makubacki enabled auto-merge (squash) November 6, 2023 21:13
@makubacki makubacki merged commit fced535 into microsoft:main Nov 6, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature-request A new feature proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants