Turn on SMM as emulated var store is no good for DFCI

microsoft · May 1, 2023 · 185b603 · 185b603
1 parent c1b5f7a
commit 185b603
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/DfciDutFiles/BuildDfci.py b/DfciDutFiles/BuildDfci.py
@@ -18,7 +18,7 @@
     args = " BLD_*_GUI_FRONT_PAGE=TRUE"
     args += " BLD_*_NETWORK_ALLOW_HTTP_CONNECTIONS=TRUE"
     args += " BLD_*_QEMU_CORE_NUM=4"
-    args += " BLD_*_SMM_ENABLED=FALSE"
+    args += " BLD_*_SMM_ENABLED=TRUE"
     args += " --clean"
 
     cmd = platformbuild + args

diff --git a/DfciDutFiles/RunDfci.py b/DfciDutFiles/RunDfci.py
@@ -60,7 +60,7 @@
         args += " ALT_BOOT_ENABLE=TRUE"
 
     args += " BLD_*_QEMU_CORE_NUM=4"
-    args += " BLD_*_SMM_ENABLED=FALSE"
+    args += " BLD_*_SMM_ENABLED=TRUE"
 
     cmd = platformbuild + args
     os.system(cmd)
diff --git a/Platforms/QemuQ35Pkg/Plugins/QemuRunner/QemuRunner.py b/Platforms/QemuQ35Pkg/Plugins/QemuRunner/QemuRunner.py
@@ -86,7 +86,8 @@ def Runner(env):
                 accel = ",accel=whpx"
 
         args += " -machine q35,smm=" + smm_enabled + accel
-        if env.GetValue("PATH_TO_OS") is not None:
+        path_to_os = env.GetValue("PATH_TO_OS")
+        if path_to_os is not None:
             # Potentially dealing with big daddy, give it more juice...
             args += " -m 8192"
             #args += " -hda \"" + path_to_os + "\""